[logstash-integration] fix: build fails when logstash version number unit >= 10#935
Open
imfms wants to merge 1 commit into
Open
[logstash-integration] fix: build fails when logstash version number unit >= 10#935imfms wants to merge 1 commit into
imfms wants to merge 1 commit into
Conversation
RockteMQ-AI
reviewed
Jun 12, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Review by github-manager-bot
Summary
Fixes the logstash integration build failure when the Logstash version number has multi-digit segments (e.g., 7.17.23). The file glob pattern ?.?.? only matches single-digit version segments; changing to *.*.* allows any digit count.
Findings
-
[Info]
build.gradle(input + output) — The wildcard change from?.?.?to*.*.*is correct and minimal. It fixes the build for Logstash versions like 7.17.23 where the patch version has 2+ digits. -
[Warning] PR Age: This PR has been open since July 2024. Consider whether the logstash-integration module is still actively maintained. If so, this fix should be merged.
Verdict
Correct one-line fix. LGTM.
Automated review by github-manager-bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[logstash-integration] fix: build fails when logstash version number unit >= 10
Brief changelog
only change some file match rule
?.?.?->*.*.*Verifying this change
logstash '7.17.21'
xxx-?.?.?.jar, so it's not in classpath)xxx-*.*.*.jar, it's in classpath)Follow this checklist to help us incorporate your contribution quickly and easily. Notice,
it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR.[ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyleto make sure basic checks pass. Runmvn clean install -DskipITsto make sure unit-test pass. Runmvn clean test-compile failsafe:integration-testto make sure integration-test pass.