Skip to content

chore(deps-dev): bump typescript from 5.4.5 to 6.0.3 in /superset-frontend#39512

Open
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/npm_and_yarn/superset-frontend/typescript-6.0.3
Open

chore(deps-dev): bump typescript from 5.4.5 to 6.0.3 in /superset-frontend#39512
dependabot[bot] wants to merge 1 commit intomasterfrom
dependabot/npm_and_yarn/superset-frontend/typescript-6.0.3

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 21, 2026

Bumps typescript from 5.4.5 to 6.0.3.

Release notes

Sourced from typescript's releases.

TypeScript 6.0.3

For release notes, check out the release announcement blog post.

Downloads are available on:

TypeScript 6.0

For release notes, check out the release announcement blog post.

Downloads are available on:

TypeScript 6.0 Beta

For release notes, check out the release announcement.

Downloads are available on:

TypeScript 5.9.3

Note: this tag was recreated to point at the correct commit. The npm package contained the correct content.

For release notes, check out the release announcement

Downloads are available on:

TypeScript 5.9

Note: this tag was recreated to point at the correct commit. The npm package contained the correct content.

For release notes, check out the release announcement

... (truncated)

Commits
  • 050880c Bump version to 6.0.3 and LKG
  • eeae9dd 🤖 Pick PR #63401 (Also check package name validity in...) into release-6.0 (#...
  • ad1c695 🤖 Pick PR #63368 (Harden ATA package name filtering) into release-6.0 (#63372)
  • 0725fb4 🤖 Pick PR #63310 (Mark class property initializers as...) into release-6.0 (#...
  • 607a22a Bump version to 6.0.2 and LKG
  • 9e72ab7 🤖 Pick PR #63239 (Fix missing lib files in reused pro...) into release-6.0 (#...
  • 35ff23d 🤖 Pick PR #63163 (Port anyFunctionType subtype fix an...) into release-6.0 (#...
  • e175b69 Bump version to 6.0.1-rc and LKG
  • af4caac Update LKG
  • 8efd7e8 Merge remote-tracking branch 'origin/main' into release-6.0
  • Additional commits viewable in compare view

@dependabot dependabot Bot added dependabot npm Dependabot - npm related PRs labels Apr 21, 2026
@bito-code-review
Copy link
Copy Markdown
Contributor

bito-code-review Bot commented Apr 21, 2026

Bito Automatic Review Skipped - Files Excluded

Bito didn't auto-review this change because all changed files are in the exclusion list for automatic reviews. No action is needed if you didn't intend for the agent to review it. Otherwise, to manually trigger a review, type /review in a comment and save.
You can change the excluded files settings here, or contact your Bito workspace admin at evan@preset.io.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.58%. Comparing base (b2468d3) to head (525507c).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #39512   +/-   ##
=======================================
  Coverage   64.57%   64.58%           
=======================================
  Files        2564     2564           
  Lines      133560   133560           
  Branches    31032    31032           
=======================================
+ Hits        86252    86256    +4     
+ Misses      45816    45812    -4     
  Partials     1492     1492           
Flag Coverage Δ
javascript 66.53% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/superset-frontend/typescript-6.0.3 branch 5 times, most recently from 68a361b to cfcaed7 Compare April 21, 2026 21:03
@rusackas
Copy link
Copy Markdown
Member

Phase 0 diagnostic — what's actually blocking the TypeScript 6.0 bump

I dug into this to figure out whether the 9,475 errors reported by CI represent the real scope of the migration or not. Good news: the real scope is dramatically smaller than it looks.

Setup

  • Bumped to TS 6.0.3, clean npm ci
  • rm -rf packages/*/lib plugins/*/lib + deleted *.tsbuildinfo
  • Ran root tsc --build

Error count by compiler-option regime

Config Total errors
Clean build, noEmitOnError: true (repo default) 9,475
Same build, noEmitOnError: false 63

That ~150× ratio is the whole story. Here's what's happening:

  1. The repo uses project references (composite: true).
  2. Upstream packages like superset-core have a handful of real TS 6.0 errors (class-property init + CSS side-effect import declarations + the baseUrl deprecation — 10 errors total).
  3. With noEmitOnError: true, those 10 errors block emission of packages/superset-core/lib/**/*.d.ts.
  4. Every downstream package and the main src/ tree then fails with TS6305 for each import of @apache-superset/core / @superset-ui/core, and because the types don't resolve, every destructured prop falls back to any — producing ~2,500 spurious TS7006/TS7031 errors plus ~500 TS2339s.

Fix the upstream 10, and the cascade vanishes.

The real error set (63 errors, 36 files)

With emission forced (noEmitOnError: false), the actual TS 6.0 migration surface is:

Errors Code Fix
24 TS5101 Add \"ignoreDeprecations\": \"6.0\" to root tsconfig.json and each package/plugin tsconfig that sets baseUrl
20 TS4023 Export the referenced type from its source module (affects src/dashboard/components/gridComponents/index.ts, src/explore/components/controls/index.ts, withAsyncVerification.tsx, TabbedSqlEditors/index.tsx)
8 TS4082 Name the default-export type explicitly (Dashboard.ts, DashboardGrid.tsx, FilterScope.tsx, reducerIndex.ts, TabbedSqlEditors)
5 TS2883 Add an explicit return-type annotation for StyledJsonEditor (DatabaseModal/styles.ts) and StyledCronPicker (ReportModal/styles.tsx)
4 TS4058 Related to the TS4082 fixes in TabbedSqlEditors
2 TS9006 Add explicit annotations in spec/fixtures/mockDashboardFilters.js, mockStore.js

Plus the 10 upstream errors (TS2564 in Theme.tsx, TS2882 in GlobalStyles.tsx, TS5101 in each package tsconfig) that are already counted above or fall under the same categories.

That totals roughly 35–40 files of mechanical edits, no design decisions, no large-scale rewrites.

Revised migration plan

Given the real scope, this is much closer to a single PR than the ~15-PR estimate I initially sketched. Reasonable staging:

  1. Phase A — tsconfig hygiene + CSS module declarations (new PR, can land today on TS 5.4)

    • ignoreDeprecations: \"6.0\" in ~24 tsconfigs (caveat: may require TS 5.5+ — checking)
    • Add *.d.ts declaring @fontsource/* CSS side-effect modules
    • Add definite-assignment (!) to Theme.tsx class properties
  2. Phase B — declaration-emit annotations (new PR on TS 5.4)

    • Fix the TS4023/TS4058/TS4082/TS9006/TS2883 cases by exporting/annotating types in the ~10 affected files.
    • These are all forward-compatible with TS 5.4.
  3. Phase C — the actual bump (rebase this PR)

    • Once A and B land, the TS 5.4.5 → 6.0.3 diff is just package.json/package-lock.json.

The flaky FiltersConfigModal keyboard-reorder 30s timeout from the original triage is unrelated to TS and should be handled separately.

Next step

I'll open the Phase A PR shortly. Holding this PR open as tracker for the full migration.

@rusackas
Copy link
Copy Markdown
Member

Phase A is up for review: #39530

Following up on the Phase 0 diagnostic above — I split out the forward-compatible subset of fixes into #39530 so they can land on TS 5.4 today without waiting for the full bump.

Phase A contents (20 files):

  • TS2883 — as typeof Component casts on styled(JsonEditor) / styled(CronPicker) (named-reference emit)
  • TS2882 — declare module '@fontsource/*' for side-effect CSS imports
  • TS2564 — definite-assignment on Theme.tsx class fields
  • TS4023/TS4082 — export on 15 interfaces/types reachable from exported symbols

Verified clean on TS 5.4.5 (tsc --build + full pre-commit suite). All 65 CI checks green.

Remaining for this PR (Phase C): once Phase A lands, the TS 5.4 → 6.0 bump itself becomes a smaller diff focused on tsconfig.json (baseUrl removal, ignoreDeprecations: "6.0") and any straggler cases. I'd suggest closing this Dependabot PR once #39530 merges so Dependabot re-opens a fresh bump against the already-prepared tree.

Bumps [typescript](https://github.com/microsoft/TypeScript) from 5.4.5 to 6.0.3.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Commits](microsoft/TypeScript@v5.4.5...v6.0.3)

---
updated-dependencies:
- dependency-name: typescript
  dependency-version: 6.0.3
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot force-pushed the dependabot/npm_and_yarn/superset-frontend/typescript-6.0.3 branch from cfcaed7 to 525507c Compare April 22, 2026 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant