Skip to content

Slash Commands#46

Draft
techpluscraft wants to merge 2 commits into
apat7:mainfrom
techpluscraft:main
Draft

Slash Commands#46
techpluscraft wants to merge 2 commits into
apat7:mainfrom
techpluscraft:main

Conversation

@techpluscraft

Copy link
Copy Markdown
Contributor

Adding Slash to Proj. Glow

@techpluscraft techpluscraft marked this pull request as draft January 28, 2022 00:32
@apat7

apat7 commented Jan 28, 2022

Copy link
Copy Markdown
Owner

Dont transision commands into slash commands, instead create a cog for all the slash commands

@techpluscraft

Copy link
Copy Markdown
Contributor Author

Dont transision commands into slash commands, instead create a cog for all the slash commands

ill do that after I finish with slash

@VincentRPS VincentRPS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some few nits, and also what glow said

Comment thread cogs/util.py
defined by the Mozilla Public License, v. 2.0. """

import time
from unicodedata import name

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused import?

Comment thread cogs/util.py
@commands.command(description="Shows the user's info.")
async def userinfo(self, ctx, *, user: nextcord.Member = None): # b'\xfc'
@slash_command(name="userinfo",description="Shows the user's info.")
async def userinfo(self, interaction:Interaction, *, user: nextcord.Member = None): # b'\xfc'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't follow pep8, aswell as the one on the top and others

Comment thread cogs/util.py
guild = interaction.guild
if interaction.user.guild_permissions.manage_emojis:
async with aiohttp.ClientSession() as ses:
async with ses.get(url) as r:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of api latency etc, maybe defer this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants