fix(e2e): audio/images propagation predicates tolerate transport failures#589
Conversation
…ures waitConfigPropagation polled with a bare fetch: a connection the DP drops mid-write while the route is still propagating (EPIPE) threw out of the predicate and failed the spec. Wrap in try/catch -> false, the same contract every other spec's predicate uses.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates E2E test propagation readiness checks for both ChangesPropagation readiness with transport error tolerance
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
Comment |
CI flake root-cause (seen on #587's e2e job):
audio-images-usage-e2epollswaitConfigPropagationwith a barefetch— when the DP drops the connection mid-multipart-write while the route is still propagating, the predicate throwsTypeError: fetch failed (EPIPE)instead of returning false, failing the spec. Both call sites now wrap the probe in try/catch → false, the same contract every other spec's predicate follows. Test-only change.Summary by CodeRabbit
Part of api7/AISIX-Cloud#519 (surfaced while landing finding B.8's PR).
Closes api7/AISIX-Cloud#519