refactor(aisix-cp): rename chart aisix-cloud → aisix-cp; default to public images#301
Conversation
…public images The chart is the private/self-hosted control-plane deployment, so it should not be branded "cloud" — rename it to aisix-cp to match the aisix-cp-* image names. Renames the chart directory, Chart name, all template helper prefixes (aisix-cloud.* -> aisix-cp.*), labels, secret names, README, ct-lint path, and the AGENTS entry. Also default the component images to docker.io/api7 instead of ghcr.io/api7. The ghcr images are private (not publicly pullable), so a self-hosted install could not pull them; the Docker Hub mirror is public and is the intended source for private deployments. Verified by installing the renamed chart on a kind cluster (public images pulled, all four pods healthy) and walking the dashboard main flow end to end (org, environment, provider key, model, API key).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (20)
💤 Files with no reviewable changes (2)
📝 WalkthroughWalkthroughThe Changesaisix-cloud → aisix-cp Helm Chart Rename
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Rename
The chart is the private / self-hosted control-plane deployment, so it shouldn't be branded "cloud". Renames it to aisix-cp to match the
aisix-cp-*image names:charts/aisix-cloud/→charts/aisix-cp/Chart.yamlnameaisix-cloud→aisix-cp, description "AISIX-Cloud control plane" → "AISIX control plane"aisix-cloud.*→aisix-cp.*(fullname, labels, secret names, DSN helpers, …)README.md, updated thect lintpath inci.yaml, and theAGENTS.mdtable rowResource names become
aisix-cp,aisix-cp-api,aisix-cp-dpm,aisix-cp-ui,aisix-cp-postgresql,aisix-cp-secrets.Public images
Also default the component images to
docker.io/api7instead ofghcr.io/api7. The ghcr images are private (not publicly pullable), so a self-hosted install couldn't pull them; the Docker Hub mirror is public and is the intended source for private deployments.api.dpImagedefault and the NOTES snippet follow suit.Verification
Installed the renamed chart on a kind cluster — public images pulled, all four pods (
postgres/api/dpm/ui) healthy — and walked the dashboard main flow end to end (signup, organization, environment, OpenRouter provider key, model, API key), all persisted in the database.Summary by CodeRabbit
New Features
aisix-cpHelm chart for AISIX control plane deployment with updated documentation and service configurations.Chores