Repository navigation
reactive-tasks 1.2.0 - #5
Merged
Merged
Conversation
- finishedStates(handle, replayLast): finished states only, replays the last finished job even while another one runs (remo results(replayLast)) - runningStates(handle): isRunning as a Flow, goes false after a cancel (remo JobFlow.state for progress) - successResults/errors(replayFinished = true) replay the last finished job during a re-run, then filter, as remo did
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
reactive-tasks 1.2.0. Source compatible with 1.1.0; no new
RunStatevalue.Restores two remo semantics that apps lost when migrating from remo 1.2.0 / 9.0.1.
Added
finishedStates(handle, replayLast = false): Flow<JobState>: finished (success or error) states only. WithreplayLast = trueit replays the last finished job even while another job of the task runs. Never completes on job cancellation. Equivalent of remoresults(replayLast).runningStates(handle): Flow<Boolean>:isRunning(handle)as a flow. Goes back tofalseafter a job is cancelled (remo reset its state to Idle;jobStatesemits nothing on cancel, so progress built on it stayedtrue).Changed
successResults(handle, replayFinished = true)anderrors(handle, replayFinished = true)replay the last finished job during a re-run, then filter it, as remosuccessResults/errors(replayLast)did. In 1.1.0 a subscriber arriving during a re-run got nothing until the current run finished.Tests
JVM and Android host: SchedulerTest 21/21, ObserveStateChangesTest 18/18 (7 new), ConcurrentCollectionsTest 5/5. iOS targets compile; iOS tests run on CI only.