Repository navigation
Ask each node once when a sink's event falls back to the whole tree (0.10.3) - #12
Merged
Merged
Conversation
…0.10.3) An event sent through a node's eventSink which nobody handled in the sink's scope was resolved again from the whole tree, so the scope's nodes got it twice: transition() and the onPreTransition hooks ran again. A node doing its work in transition() and answering Ignore did that work twice. The scoped resolution and the fallback now share the set of paths already asked; a node in it is skipped and counts as Ignore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An event sent through a node's
eventSinkwhich nobody handled in the sink's scope was resolved again from the whole tree, so the scope's nodes got it twice:transition()and theonPreTransitionhooks ran again. A node doing its work intransition()and answeringIgnoredid that work twice.The scoped resolution and the fallback now share the set of paths already asked; a node in it is skipped and counts as
Ignore. The whole-tree fallback itself is kept, so sibling regions still get an event nobody in scope handled.Bumps the version to 0.10.3.