Repository navigation
Schema extension, lazy regions, focused region host (0.11.0) - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the workarounds the apps needed for tabs built on
parallelFlow, and fixes the parallel-flow bugs found while migrating them.Added
.dotfile withmode = "extend"adds nodes and edges to the schema with the same graph id instead of replacing it, so the schema is not copied into the flavor's source set.Path.endsWith(target: Target)instead of a string comparison of the last segment.ParallelFlowNode.initialRegions,startRegion,isRegionStarted: regions which are not initial have no nodes until they are started, so tabs can load on the first selection without placeholder nodes.isRegionAtRootmakes the state of a region readable intransition().BaseParallelFlowNode: a parallel flow node with hooks.way-compose:FocusedRegionHost(regionId)renders one region of a parallel node and keeps the saved state of the other ones;rememberTransitionSpec()with push, pop, fade and no-op transitions.Changed
way-composehosts start from the current state of the service, so a host which enters composition later shows its node on the first frame.NodeBuilderhassnapshotCacheandrestoreCache; a hand-written builder which caches child builders should override them.Fixed
NavigateTo.RegionId.resolveAbsoluteand from relative targets inside of a parallel.onEntrythrew getsonExit.The full list is in
CHANGELOG.md.Source-breaking: a
ParallelFlowNodesubclass which declares a member namedinitialRegions,startRegion,isRegionStartedorisRegionAtRoothas to rename it.Checked with
:way:allTests,:way-gradle-plugin:test,:way-compose:testDebugUnitTest, and with six apps built against the local artifacts and run on an emulator.Bumps the version to 0.11.0.