Repository navigation
Fix codegen for nested local flows and history under parallel; DSL full targets and region ids (0.13.0) - #23
Merged
Merged
Conversation
The history node was listed among the parallel's regions, so the generated builder failed as soon as the parallel flow was entered. A parallel with only history children now counts as empty. Closes #20
A non-root local flow builder shares the schema of its root. Its targetOrError passed the alias to schema.target, which replaces the schema root, not the flow's own prefix, so the flow segment appeared twice (settings.settings.general) and the build failed. Targets are now re-based onto the flow's own segment. The DSL parity test uses the generated SettingsNodeBuilder and ShopNodeBuilder instead of hand-built ones. Closes #19
ParallelRef.regionId(child) gives the region id relative to the parallel's schema, the same as a generated <child>RegionId, in place of Schema.regionByName. Closes #22
target(..., shop with shopId, item with itemId) fills ancestorPayloads, so ancestors which are not alive are rebuilt, like a generated full target. Every ancestor must be a parameterized ancestor of the target. Closes #21
This was referenced Nov 9, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19 #20 #21 #22
Fixes (Gradle plugin)
settings.settings.general) and the builder crashed. TheNb01login/Nb01onboardingsnapshots encoded the bug and were regenerated.history/deepHistorychild of aparallelFlowis no longer a region, inbuildRegionRootsand in the parallel builder'sRegionIdloop. A parallel with only history children counts as empty.SettingsNodeBuilder/ShopNodeBuilderin place of the hand-built workarounds, and checkstabsHistoryagainst the generated graph.Additions (way-dsl)
promo.target(shop with "s1", item with 5)fillsancestorPayloads, the same as a generated full target. Every ref must be a parameterized ancestor. A newdsl-parity-full.dotparity test cold-navigates into a branch that is not alive and compares the result with the generated graph.ParallelRef.regionId(child)returns the region id relative to the parallel's schema, the same as a generated<child>RegionId.Release / CI
versionNameis now 0.13.0, and the CHANGELOG section is dated. The tag is pushed after merge.ios-testsjob onmacos-latestruns:way:iosSimulatorArm64Testand:way-dsl:iosSimulatorArm64Test. These tests have never run before.