Skip to content

[PL-396]: Sync mobsfscan component manifest with the component repo - #818

Merged
boztopuz merged 2 commits into
testingfrom
feature/PL-396-dev
Aug 26, 2026
Merged

[PL-396]: Sync mobsfscan component manifest with the component repo#818
boztopuz merged 2 commits into
testingfrom
feature/PL-396-dev

Conversation

@boztopuz

Copy link
Copy Markdown
Contributor

Brings appcircle_mobsfscan/1.0.0/component.yaml in line with appcircle-mobsfscan-component@02139b1. Manifest only, one file changed.

files: gains mobsf.rb

This is the release blocking part. The component split the advance scan mode out of main.rb into mobsf.rb, and a file that is not listed under files: is never shipped to the runner. Publishing the entry without it leaves the advance mode failing at require time, while the light scan keeps working, so the breakage would only show up for users who pick advance.

Two inputs removed, 16 down to 14

AC_MOBSFSCAN_MOBSF_PREFIX and AC_MOBSFSCAN_MOBSF_CONTROL are gone. A provisioned runner has both and the step finds them on its own, confirmed on a dev macOS runner: the manifest at /usr/local/appcircle/mobsf and the control script at <runner>/scripts/mobsf-control.sh. When a runner has neither, the step reports why and runs the light scan, so the two fields only crowded the form without buying an escape hatch.

Descriptions shortened

The select descriptions were being squeezed in the step details interface. The longest description is now 102 characters against 348, in line with appcircle_ios_filesize and appcircle_android_maestro_cloud_upload.

commit moves to 02139b1

From 6fcf4fc. That component commit is on feature/PL-396, which is still open as appcircleio/appcircle-mobsfscan-component#1 — worth confirming the hash survives however that PR is merged, since a squash merge would leave it unreachable.

Verified

  • YAML parses; 14 inputs, 11 outputs.
  • Every select input's defaultValue is one of its own options, per the integration guide.
  • The inputs/outputs/processFilename/processArguments/files blocks are byte identical to the component repo's component.yaml, so the two cannot drift.
  • The component side is green: 140 RSpec examples, 115 unit and 25 end to end, including the advance mode driven against a stand-in mobsf-control.sh planted the way a real runner is laid out.

Not in this PR

platform: Common and buildPlatform: JavaKotlin, ObjectiveCSwift are unchanged: the step stays on the Android and iOS native profiles. mobsfscan reads only .java, .kt, .swift and .m, so React Native and Flutter app code is outside its rule set, and auto detection resolves a tree holding both natives to Android alone.

🤖 Generated with Claude Code

Brings the registry entry in line with appcircle-mobsfscan-component at
02139b1.

`files:` gains mobsf.rb. The component split the advance scan mode into a
second file, and a file that is not listed here is never shipped to the
runner, so without this entry the advance mode would fail at require time.

The MobSF installation prefix and control script inputs are gone, 16 inputs
down to 14. A provisioned runner has both and the step finds them: on a dev
macOS runner the manifest sits at /usr/local/appcircle/mobsf and the script
at <runner>/scripts/mobsf-control.sh. When a runner has neither, the step
falls back to the light scan, so the two fields only crowded the form.

Descriptions are shortened, the select ones most of all, since they were
being squeezed in the step details interface. The longest is now 102
characters against 348.

commit moves from 6fcf4fc to 02139b1.
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dc30c579-dbd5-445f-8df8-4564533b7c50

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

Follows appcircle-mobsfscan-component at f4439c3.

The pip index and find-links inputs are removed, 14 inputs down to 12. pip
reads PIP_INDEX_URL, PIP_NO_INDEX and PIP_FIND_LINKS from the environment
on its own, and the step does not clear them, so an Environment Variable
group already covers the air gapped case. That is also the right home for
them: a credentialed index URL is a secret and there is no secret input
type, so it should not sit in a plain step field.

The severity gate now offers critical / normal / low / none instead of
error / warning / info / none, with the title "Fail Build On" so the field
says what it does. Same at-or-above mechanism, same default behaviour:
critical is the old error. critical maps to mobsfscan ERROR and MobSF high,
normal to WARNING and warning, low to INFO and info.

commit moves from 02139b1 to f4439c3.
@boztopuz
boztopuz merged commit 119f5c8 into testing Aug 26, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant