[PL-396]: Sync mobsfscan component manifest with the component repo - #818
Merged
Conversation
Brings the registry entry in line with appcircle-mobsfscan-component at 02139b1. `files:` gains mobsf.rb. The component split the advance scan mode into a second file, and a file that is not listed here is never shipped to the runner, so without this entry the advance mode would fail at require time. The MobSF installation prefix and control script inputs are gone, 16 inputs down to 14. A provisioned runner has both and the step finds them: on a dev macOS runner the manifest sits at /usr/local/appcircle/mobsf and the script at <runner>/scripts/mobsf-control.sh. When a runner has neither, the step falls back to the light scan, so the two fields only crowded the form. Descriptions are shortened, the select ones most of all, since they were being squeezed in the step details interface. The longest is now 102 characters against 348. commit moves from 6fcf4fc to 02139b1.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Follows appcircle-mobsfscan-component at f4439c3. The pip index and find-links inputs are removed, 14 inputs down to 12. pip reads PIP_INDEX_URL, PIP_NO_INDEX and PIP_FIND_LINKS from the environment on its own, and the step does not clear them, so an Environment Variable group already covers the air gapped case. That is also the right home for them: a credentialed index URL is a secret and there is no secret input type, so it should not sit in a plain step field. The severity gate now offers critical / normal / low / none instead of error / warning / info / none, with the title "Fail Build On" so the field says what it does. Same at-or-above mechanism, same default behaviour: critical is the old error. critical maps to mobsfscan ERROR and MobSF high, normal to WARNING and warning, low to INFO and info. commit moves from 02139b1 to f4439c3.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings
appcircle_mobsfscan/1.0.0/component.yamlin line with appcircle-mobsfscan-component@02139b1. Manifest only, one file changed.files:gainsmobsf.rbThis is the release blocking part. The component split the advance scan mode out of
main.rbintomobsf.rb, and a file that is not listed underfiles:is never shipped to the runner. Publishing the entry without it leaves the advance mode failing at require time, while the light scan keeps working, so the breakage would only show up for users who pickadvance.Two inputs removed, 16 down to 14
AC_MOBSFSCAN_MOBSF_PREFIXandAC_MOBSFSCAN_MOBSF_CONTROLare gone. A provisioned runner has both and the step finds them on its own, confirmed on a dev macOS runner: the manifest at/usr/local/appcircle/mobsfand the control script at<runner>/scripts/mobsf-control.sh. When a runner has neither, the step reports why and runs the light scan, so the two fields only crowded the form without buying an escape hatch.Descriptions shortened
The select descriptions were being squeezed in the step details interface. The longest description is now 102 characters against 348, in line with
appcircle_ios_filesizeandappcircle_android_maestro_cloud_upload.commitmoves to 02139b1From
6fcf4fc. That component commit is onfeature/PL-396, which is still open as appcircleio/appcircle-mobsfscan-component#1 — worth confirming the hash survives however that PR is merged, since a squash merge would leave it unreachable.Verified
selectinput'sdefaultValueis one of its ownoptions, per the integration guide.inputs/outputs/processFilename/processArguments/filesblocks are byte identical to the component repo'scomponent.yaml, so the two cannot drift.mobsf-control.shplanted the way a real runner is laid out.Not in this PR
platform: CommonandbuildPlatform: JavaKotlin, ObjectiveCSwiftare unchanged: the step stays on the Android and iOS native profiles. mobsfscan reads only.java,.kt,.swiftand.m, so React Native and Flutter app code is outside its rule set, andautodetection resolves a tree holding both natives to Android alone.🤖 Generated with Claude Code