ci(codeql): switch to advanced workflow + drop default setup#72
ci(codeql): switch to advanced workflow + drop default setup#72jbdevprimary merged 1 commit intomainfrom
Conversation
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
📝 WalkthroughWalkthroughA new GitHub Actions workflow for CodeQL static analysis has been added. The workflow triggers on pushes, pull requests to main, and a weekly schedule, analyzing both JavaScript/TypeScript and GitHub Actions code using the security-and-quality query suite. ChangesCodeQL Workflow Configuration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
This PR successfully replaces the default CodeQL setup with an advanced workflow that addresses the Enterprise ruleset requirement. The workflow configuration is sound with proper triggers, permissions, and concurrency controls. No blocking issues identified.
You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/codeql.yml:
- Around line 56-70: Replace the mutable action tags used in the workflow
(actions/checkout@v4, github/codeql-action/init@v3,
github/codeql-action/analyze@v3) with their corresponding full-length immutable
commit SHAs; locate the steps named "Checkout", "Initialize CodeQL", and
"Perform CodeQL Analysis" in the workflow and update the uses: values to the
pinned commit SHAs for those action repositories, ensuring you copy the exact
full commit hashes from the official action repositories/releases and run a
quick workflow lint to verify syntax.
- Around line 17-27: Add the missing merge_group trigger to the workflow's
top-level on: configuration so the workflow also runs for merge queue events;
update the event list alongside existing keys ('push', 'pull_request',
'schedule') to include 'merge_group' (and mirror any required filters used for
pull_request if needed) so required checks report correctly when using the merge
queue.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1d1c7a4f-1450-4bf4-a101-b26e6ae1964f
📒 Files selected for processing (1)
.github/workflows/codeql.yml
Bot reviewer; nice-to-haves not blocking
Two follow-ups to the workflow that landed in PR #72: 1. workflow_dispatch trigger so we can manually run scans against branches already behind the Enterprise PRs ruleset (the rule rejects the push that would otherwise trigger the scan — classic chicken-and-egg with no other escape hatch). 2. Single-quoted yaml string at line 71 to match the local Prettier config (the canonical version was double-quoted; this repo uses singleQuote in its prettier config).
Disables default-setup CodeQL (which only runs on push to default branch and weekly) and replaces it with a custom workflow that runs on push to all branches.
This unblocks pushes to feature branches when the Enterprise PRs ruleset code_scanning rule is active — default-setup never runs against feature-branch pushes, so the rule rejects them indefinitely with Waiting for Code Scanning results.
Maintained centrally at github.com/jbdevprimary/gh-fleet-sync.
Summary by CodeRabbit