Skip to content

feat: add saved searches - #36

Merged
arnabnandy7 merged 7 commits into
arnabnandy7:mainfrom
ShashankShekhar31:fix/issue-13-saved-searches
Aug 19, 2026
Merged

feat: add saved searches#36
arnabnandy7 merged 7 commits into
arnabnandy7:mainfrom
ShashankShekhar31:fix/issue-13-saved-searches

Conversation

@ShashankShekhar31

Copy link
Copy Markdown
Contributor

Summary

Implements saved searches for the issue finder using browser localStorage.

Changes

  • Added typed saved-search storage logic using localStorage
  • Saves the current technology, issue label, sort order, linked PR filter, and Hacktoberfest filter
  • Added saved search names
  • Added persistence across browser sessions
  • Added rerun functionality with all saved filters restored
  • Added delete functionality for saved searches
  • Safely handles missing or invalid stored data
  • Kept storage logic separate so account-based persistence can be added later

Validation

  • git diff --check passes
  • npm run build passes
  • Tested saving a search
  • Tested persistence after restarting/refreshing
  • Tested rerunning a saved search with filters restored
  • Tested deleting a saved search
  • Checked browser console for errors

Closes #13

Copilot AI lite review requested due to automatic review settings August 18, 2026 19:03
@vercel

vercel Bot commented Aug 18, 2026

Copy link
Copy Markdown

@ShashankShekhar31 is attempting to deploy a commit to the arnabnandy7's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds “saved searches” to the Issue Finder, persisting user-selected filters (tech/label/sort/linked PR/Hacktoberfest) in browser localStorage so searches can be rerun or deleted across sessions.

Changes:

  • Introduces typed localStorage persistence utilities for saved searches (load/add/delete + validation).
  • Extends the Issue Finder UI to save the current filter set under a user-provided name, list saved searches, rerun them, and delete them.
  • Adds a search “override” pathway so rerunning a saved search uses the saved parameters immediately.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/features/issues/lib/saved-searches.ts Adds saved-search storage/validation helpers backed by localStorage.
src/features/issues/components/issue-finder.tsx Adds Saved Searches UI + wiring to persist, rerun, and delete saved searches.
Suppressed comments (3)

src/features/issues/components/issue-finder.tsx:126

  • The body of handleRunSavedSearch is not indented consistently with the rest of this file; formatting it will improve readability and keep the file consistent.
  setTech(savedSearch.tech);
  setLabel(savedSearch.label);
  setSort(savedSearch.sort);
  setLinkedPr(savedSearch.linkedPr);
  setHacktoberfest(savedSearch.hacktoberfest);

src/features/issues/components/issue-finder.tsx:141

  • The searchIssues parameter list and the initial override-handling block are not indented consistently (compared to the rest of the function and surrounding code), which hurts readability and can trip format/lint checks.
  async function searchIssues(
  event?: FormEvent<HTMLFormElement>,
  searchOverride?: {
    tech: string;
    label: string;

src/features/issues/components/issue-finder.tsx:413

  • The new "Saved searches" <Card> block has inconsistent JSX indentation (child components are less-indented than the parent), which makes this section much harder to scan and maintain.
          <Card>
  <CardHeader>
    <CardTitle className="text-base">Saved searches</CardTitle>
    <CardDescription>
      Save your current filters and reuse them later.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/features/issues/components/issue-finder.tsx Outdated
Comment thread src/features/issues/lib/saved-searches.ts
@vercel

vercel Bot commented Aug 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
openissue-dev Ready Ready Preview Aug 19, 2026 3:42pm

@arnabnandy7 arnabnandy7 left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the implementation is well separated and validates stored records, but I recommend addressing these two reliability issues before merging. I've synced with main for you, take a pull before making any further changes

Comment thread src/features/issues/components/issue-finder.tsx
Comment thread src/features/issues/lib/saved-searches.ts Outdated
Comment thread src/features/issues/lib/saved-searches.ts
@sonarqubecloud

Copy link
Copy Markdown

@ShashankShekhar31

Copy link
Copy Markdown
Contributor Author

Addressed the requested review feedback:

  • Disabled the Run button while a search is loading or cooldown is active.
  • Updated saved-search persistence so the UI is only updated after storage succeeds.
  • Added error handling for storage failures.

Also verified locally with git diff --check and npm run build.

The latest changes are pushed to the PR.

Comment thread .github/workflows/sonarcloud.yml
@arnabnandy7
arnabnandy7 merged commit a635a70 into arnabnandy7:main Aug 19, 2026
3 of 4 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Completed in Open issue portal development Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Development

Successfully merging this pull request may close these issues.

Saved searches

3 participants