Skip to content

fix(factory): handle explicit tzinfo=None in arrow.get() #1273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
armorbreak001 wants to merge 1 commit into
base: master
Choose a base branch
from
+8 −3
Open

fix(factory): handle explicit tzinfo=None in arrow.get() #1273

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions arrow/factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,17 +188,22 @@ def get(self, *args: Any, **kwargs: Any) -> Arrow:

arg_count = len(args)
locale = kwargs.pop("locale", DEFAULT_LOCALE)
tz = kwargs.get("tzinfo", None)
_tz_missing = object()
tz = kwargs.get("tzinfo", _tz_missing)
normalize_whitespace = kwargs.pop("normalize_whitespace", False)

# if kwargs given, send to constructor unless only tzinfo provided
if len(kwargs) > 1:
arg_count = 3

# tzinfo kwarg is not provided
if len(kwargs) == 1 and tz is None:
# tzinfo kwarg is not provided (distinguish from explicit tzinfo=None)
if len(kwargs) == 1 and tz is _tz_missing:
arg_count = 3

# Normalize explicit tzinfo=None to Python None for downstream code
if tz is _tz_missing:
tz = None

# () -> now, @ tzinfo or utc
if arg_count == 0:
if isinstance(tz, str):
Expand Down