Repository navigation
feat: add host_app_path option to link back to the host app - #440
Merged
Merged
Conversation
app.css was not regenerated after the cinder 0.17 -> 0.18 bump. Tailwind scans deps/cinder, so the new cinder-partial filter classes were missing and some unused classes were still present. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds `:host_app_path` and `:host_app_label` options to the `ash_admin` router macro. When `:host_app_path` is set, the sidebar shows a link back to the host application. `:host_app_label` defaults to "Back to app". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
🚀 Thank you for your contribution! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When AshAdmin is mounted inside an existing Phoenix app, there is no way to get back to the host app from the admin UI. This PR adds two optional options to the
ash_adminrouter macro::host_app_path: when set, the sidebar shows a link (under the title) back to this path.:host_app_label: the link label. Defaults to"Back to app".When
:host_app_pathis not set, nothing changes.Notes
chore: rebuild assets for cinder 0.18) only regeneratesapp.css, which was stale since thecinder0.17 → 0.18 bump from dependabot. Thefeat:commit then only adds thehero-arrow-left-miniicon to the CSS.test/page_live_test.exs(link present with custom label, default label, absent when not configured).