refactor: sweep remaining config forms onto shared FormField (#2051)#2081
Merged
Conversation
Follow-up to #2027. Migrate ~130 sibling <label>+input config-form fields across ~40 client files onto the shared FormField accessibility wrapper so each label's htmlFor is wired to its control id (click-to-focus + screen reader association). Accessibility only — Tailwind classes preserved verbatim; wrapping labels, radio/toggle group labels, and custom controls that don't forward id to a DOM input were deliberately left alone. Closes #2051 Claude-Session: https://claude.ai/code/session_01KSyAbxEjURcLPhugG8MZCw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2027, completing the repo-wide sweep of sibling config-form labels onto the shared
FormFieldaccessibility wrapper (client/src/components/ui/FormField.jsx), which wires<label htmlFor>↔ controlidviauseId().~130 fields migrated across ~40 files. Each converted field's label now focuses its control on click and is announced correctly by screen readers.
Areas migrated
Deliberately skipped (per #2027 rules)
<label><input/></label>) — valid implicit associations left untouched (e.g. Tribe, CreativeDirector, MusicGenPanel, StoryboardConfigTab, the localFieldcomponents in Authors/PipelineSeries/AlbumsManager/TracksManager).idto a real DOM input —ToggleSwitch,CronInput,InfluenceChipsInput,FolderPicker-wrapped rows, etc. (ModelSelectwas migrated because it does forwardidto its<select>).htmlFor(LocalLlmPlayground, many in Importer/StoryBuilder/PipelineSeries/UniverseBuilder).Test plan
FormFieldhas a non-DOM (<div>) first child, so every label binds to a real control.className/labelClassName.Closes #2051
https://claude.ai/code/session_01KSyAbxEjURcLPhugG8MZCw