Skip to content

fix(query): sound caveat resolution for recursive relations in the query planner - #3220

Draft
josephschorr wants to merge 3 commits into
authzed:mainfrom
josephschorr:query-planner-recursive-caveats
Draft

fix(query): sound caveat resolution for recursive relations in the query planner#3220
josephschorr wants to merge 3 commits into
authzed:mainfrom
josephschorr:query-planner-recursive-caveats

fix(query): sound caveat resolution and depth errors for recursive re…

2467dfd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jul 14, 2026 in 1s

80.69% of diff hit (target 76.47%)

View this Pull Request on Codecov

80.69% of diff hit (target 76.47%)

Annotations

Check warning on line 63 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L62-L63 

Added lines #L62 - L63 were not covered by tests

Check warning on line 84 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L80-L84 

Added lines #L80 - L84 were not covered by tests

Check warning on line 109 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L108-L109 

Added lines #L108 - L109 were not covered by tests

Check warning on line 166 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L165-L166 

Added lines #L165 - L166 were not covered by tests

Check warning on line 189 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L188-L189 

Added lines #L188 - L189 were not covered by tests

Check warning on line 209 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L208-L209 

Added lines #L208 - L209 were not covered by tests

Check warning on line 273 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L272-L273 

Added lines #L272 - L273 were not covered by tests

Check warning on line 276 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L275-L276 

Added lines #L275 - L276 were not covered by tests

Check warning on line 299 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L298-L299 

Added lines #L298 - L299 were not covered by tests

Check warning on line 308 in internal/caveats/canonical.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/caveats/canonical.go#L303-L308 

Added lines #L303 - L308 were not covered by tests

Check warning on line 298 in internal/datastore/proxy/indexcheck/queryshapevalidators.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/proxy/indexcheck/queryshapevalidators.go#L297-L298 

Added lines #L297 - L298 were not covered by tests

Check warning on line 307 in internal/datastore/proxy/indexcheck/queryshapevalidators.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/proxy/indexcheck/queryshapevalidators.go#L306-L307 

Added lines #L306 - L307 were not covered by tests

Check warning on line 310 in internal/datastore/proxy/indexcheck/queryshapevalidators.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/proxy/indexcheck/queryshapevalidators.go#L309-L310 

Added lines #L309 - L310 were not covered by tests

Check warning on line 313 in internal/datastore/proxy/indexcheck/queryshapevalidators.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/proxy/indexcheck/queryshapevalidators.go#L312-L313 

Added lines #L312 - L313 were not covered by tests

Check warning on line 316 in internal/datastore/proxy/indexcheck/queryshapevalidators.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

internal/datastore/proxy/indexcheck/queryshapevalidators.go#L315-L316 

Added lines #L315 - L316 were not covered by tests

Check warning on line 15 in pkg/query/errors.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/errors.go#L14-L15 

Added lines #L14 - L15 were not covered by tests

Check warning on line 414 in pkg/query/recursive.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/recursive.go#L414 

Added line #L414 was not covered by tests

Check warning on line 461 in pkg/query/recursive.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/recursive.go#L461 

Added line #L461 was not covered by tests

Check warning on line 470 in pkg/query/recursive.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/recursive.go#L469-L470 

Added lines #L469 - L470 were not covered by tests

Check warning on line 594 in pkg/query/recursive.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/recursive.go#L594 

Added line #L594 was not covered by tests

Check warning on line 598 in pkg/query/recursive.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

pkg/query/recursive.go#L597-L598 

Added lines #L597 - L598 were not covered by tests
View more details on Codecov