fix: stop inferring schema prefix from the remote schema - #710
Open
ivanauth wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
zed schema write and zed import previously read the existing schema from the server and silently rewrote the schema being written with any definition prefix found there. Writing an unprefixed schema over a prefixed one therefore became a silent no-op. This inference existed to accommodate the prefix requirement of AuthZed Serverless, which no longer applies. The schema is now written as given; the explicit --schema-definition-prefix flag still applies a prefix when requested, and schema copy still derives its prefix from the source schema text. Signed-off-by: ivanauth <ivan@authzed.com>
ivanauth
force-pushed
the
fix/issue-603-schema-write-prefix-noop
branch
from
July 27, 2026 18:58
10126a9 to
b8b4ac6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #603
zed schema writeread the existing remote schema and silently re-applied any definition prefix it found, so writing an unprefixed schema over a prefixed one was a no-op reported as success. The schema is now written as given, andzed importloses the same inference.--schema-definition-prefixstill applies an explicit prefix, andschema copystill derives its prefix from the source schema.