Refactor instance tests around a network harness - #508
Open
samliok wants to merge 6 commits into
Open
Conversation
samliok
force-pushed
the
instance-test-refactor
branch
from
August 19, 2026 18:25
97c53ab to
d147e3d
Compare
samliok
marked this pull request as ready for review
August 20, 2026 21:53
samliok
force-pushed
the
instance-test-refactor
branch
from
August 21, 2026 15:15
4bb3bc9 to
5040547
Compare
samliok
commented
Aug 21, 2026
| // order to do so. | ||
| // We then check does so by checking they participated in signing | ||
| // Equivalent test as the previous TestInstanceMixedNodeType. | ||
| func TestNonValidator_BecomesValidator(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
equivalent to the previous: TestInstanceMixedNodeType
| // TestNonValidator_StaysNonValidator ensures that a non-validator does not restart when it is processing | ||
| // previous epoch changes. | ||
| // Equivalent to TestInstanceNonValidatorBootstraps | ||
| func TestNonValidator_StaysNonValidator(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
previously was TestInstanceNonValidatorBootstraps
| // then it is no longer a validator, and finally it is | ||
| // Equivalent to: TestInstanceValidatorSkipsAnEpoch. This also starts a validator when the tip is a sealing block so it covers an edge | ||
| // case previously caught from the logging test. | ||
| func TestInstanceValidatorSkipsAnEpoch(t *testing.T) { |
Collaborator
Author
There was a problem hiding this comment.
Equivalent to: TestInstanceValidatorSkipsAnEpoch. This also starts a validator when the tip is a sealing block so it covers an edge case previously caught from the logging test.
samliok
force-pushed
the
instance-test-refactor
branch
2 times, most recently
from
August 21, 2026 15:43
7ff7591 to
ed0e6d5
Compare
samliok
force-pushed
the
instance-test-refactor
branch
from
August 21, 2026 15:56
ed0e6d5 to
ac05817
Compare
Replace the queue-based inMemNetwork with a network harness whose instanceComm delivers messages directly and re-parses blocks so recipients do not share canoto state. Scenario tests shrink to short flows against the harness, and epoch sealing tests rely on production approval dissemination instead of injecting approvals. Move TestParseBlockSizeMatchesBytes next to external.go.
… in addNodeWithConfig
samliok
force-pushed
the
instance-test-refactor
branch
from
August 21, 2026 16:01
ac05817 to
070a524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final PR of the cleanup-instance stack (4/4), on top of the transition listener PR.
instance_testhelpers_test.go, rebuilt around anetworkharness:addNode,acceptNewBlock,waitUntilSealingBlock. The queue-basedinMemNetworkis replaced byinstanceComm, which delivers messages directly and re-parses blocks so recipients do not share mutable canoto state.instance_test.gobecomes short scenario tests. Epoch sealing tests now rely on production approval/aux info dissemination instead of hand-injecting approvals (removing the old TODO).TestParseBlockSizeMatchesBytesmoves verbatim toexternal_test.gonext toexternal.go.TestNonValidator_StaysNonValidator(replacingTestInstanceNonValidatorBootstraps) is skipped pending offline-node timeouts, andTestInstanceRestartAcrossEpochsis dropped (thenode.restart()helper remains unused).