Gate messages to epoch once the epoch is sealed - #513
Draft
samliok wants to merge 6 commits into
Draft
Conversation
… VM, rework epoch transitions Extract LastBlock and epoch/validator-set derivation into util.go with tests. Split ParseBlock into a BlockDeserializer interface and move ICM epoch computation to a Config field. Replace EpochAwareStorage with InstanceStorage, which skips Telocks by block type and exposes an onIndex hook. Signal epoch changes via EpochConfig.OnSealingBlockIndex for validators and nonvalidator.Config.TransitionToValidator for non-validators instead of the storage wrapper. Rework processEpochChange to honor Stop for validators and notifyEpochChange to keep only the newest pending change.
Add Message.AuxiliaryInfo and Message.EpochTransitionApproval along with the common.AuxiliaryInfo type. Blocks now carry an AuxiliaryInfoBatch with one entry per contributing node instead of a single locally generated entry. The builder collects legal entries from a new auxInfoStore mempool populated by HandleAuxiliaryInfo, and SignApproval is exported so callers can sign and broadcast their own approvals. GetAuxiliaryHistory exposes the aux history traversal used to decide whether to generate info or approve. Note: this changes the wire format of the metadata aux info field, and the candidate digest for an empty aux history is now the zero digest instead of sha256(nil).
Construct an epochTransitionListener in NewInstance and hook its onIndex into both the validator and non-validator storage paths, so indexing a transition block generates and broadcasts auxiliary info, or signs and broadcasts an epoch transition approval once the history is sufficient. Route incoming AuxiliaryInfo and EpochTransitionApproval messages into the MSM.
yacovm
reviewed
Aug 14, 2026
| } | ||
|
|
||
| return err | ||
| if block.SealingBlockInfo() != nil && block.SealingBlockInfo().PrevSealingBlockHash != [32]byte{} { |
Collaborator
There was a problem hiding this comment.
we have the method onEpochChange in instance.go, can't we just define the variable there?
yacovm
reviewed
Aug 14, 2026
|
|
||
| func (i *Instance) handleValidatorMessage(msg *common.Message, from common.NodeID) error { | ||
| // we only want to process replication requests if the epoch is sealed | ||
| if i.cs.lastSealedEpoch == i.e.Metadata().Epoch { |
Collaborator
There was a problem hiding this comment.
why ==? What if it's a replication request for a previous epoch? Shouldn't we serve it as well?
Collaborator
Author
There was a problem hiding this comment.
this is not checking the epoch noted in the message, its strictly checking the epoch instance's metadata. So the contents of the replication request have no bearing on this check
yacovm
reviewed
Aug 14, 2026
yacovm
reviewed
Aug 14, 2026
| return nil | ||
| } | ||
|
|
||
| switch { |
Collaborator
There was a problem hiding this comment.
why do we have auxiliary info disseminated separately from the approval?
Collaborator
Author
There was a problem hiding this comment.
not sure i understand. We handle auxiliary info differently than approvals because one comes after the other. They also have different message structures
samliok
marked this pull request as draft
August 17, 2026 21:43
samliok
force-pushed
the
transition-listener
branch
6 times, most recently
from
August 21, 2026 16:01
10be7d2 to
d99a5c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.