test: point integ tests to sample app fix branch#14834
Open
soberm wants to merge 2 commits into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR triggers the E2E integration tests against the sample app fix branch
fix/remove-babel-preset-resolutioninamplify-js-samples-staging.What this does
Updates
.github/workflows/push-integ-test.ymlto trigger on thefix/remove-babel-preset-resolutionbranch. Thesetup-samples-stagingaction automatically checks out the matching branch name inamplify-js-samples-staging, so the E2E tests will run against the sample apps with the stalebabel-preset-react-app@10.0.0resolution removed.Related PR
babel-preset-react-appresolution from 10 sample apps that was breaking webpack 5 builds with ESM packages (e.g., axios).Expected outcome
The E2E tests should pass now that the sample apps use
babel-preset-react-app@10.1.0(the default for react-scripts 5.0.1), which correctly generates fully-specified imports compatible with webpack 5's ESM handling.