Skip to content

test: point integ tests to sample app fix branch#14834

Open
soberm wants to merge 2 commits into
v5-stablefrom
fix/remove-babel-preset-resolution
Open

test: point integ tests to sample app fix branch#14834
soberm wants to merge 2 commits into
v5-stablefrom
fix/remove-babel-preset-resolution

Conversation

@soberm
Copy link
Copy Markdown
Contributor

@soberm soberm commented May 28, 2026

Purpose

This PR triggers the E2E integration tests against the sample app fix branch fix/remove-babel-preset-resolution in amplify-js-samples-staging.

What this does

Updates .github/workflows/push-integ-test.yml to trigger on the fix/remove-babel-preset-resolution branch. The setup-samples-staging action automatically checks out the matching branch name in amplify-js-samples-staging, so the E2E tests will run against the sample apps with the stale babel-preset-react-app@10.0.0 resolution removed.

Related PR

  • aws-amplify/amplify-js-samples-staging#1118 — removes the babel-preset-react-app resolution from 10 sample apps that was breaking webpack 5 builds with ESM packages (e.g., axios).

Expected outcome

The E2E tests should pass now that the sample apps use babel-preset-react-app@10.1.0 (the default for react-scripts 5.0.1), which correctly generates fully-specified imports compatible with webpack 5's ESM handling.

@soberm soberm requested a review from a team as a code owner May 28, 2026 15:34
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 28, 2026

⚠️ No Changeset found

Latest commit: 3cd1a40

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant