Bump transformers from 4.57.1 to 5.3.0 in /.ci/docker - #3
Open
dependabot[bot] wants to merge 1 commit into
Open
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [transformers](https://github.com/huggingface/transformers) from 4.57.1 to 5.3.0. - [Release notes](https://github.com/huggingface/transformers/releases) - [Commits](huggingface/transformers@v4.57.1...v5.3.0) --- updated-dependencies: - dependency-name: transformers dependency-version: 5.3.0 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
aws-arashj
pushed a commit
that referenced
this pull request
Oct 5, 2026
`TorchFTOptimizersContainer` [wraps itself](https://github.com/pytorch/torchtitan/blob/d398a8fb9bc8a33ca404217a846cff65feab92f0/torchtitan/experiments/torchft/optimizer.py#L45) with `torchft.Optimizer`. On accepted steps, the wrapper [calls back into the same container](https://github.com/meta-pytorch/torchft/blob/90d7f68961e7c0bcd4278f7ebba83b5cd876c099/torchft/optim.py#L53-L56), repeatedly triggering PyTorch's [pre/post hooks](https://github.com/pytorch/pytorch/blob/e3f5bf0b18585511e6cd7d7a574ebf82f465e5ae/torch/optim/optimizer.py#L508-L540). When the base method is already wrapped, [super().step()](https://github.com/pytorch/torchtitan/blob/d398a8fb9bc8a33ca404217a846cff65feab92f0/torchtitan/experiments/torchft/optimizer.py#L76) adds a third invocation, causing redundant blocking [MoE load-balancing collectives](https://github.com/pytorch/torchtitan/blob/d398a8fb9bc8a33ca404217a846cff65feab92f0/torchtitan/components/optimizer/optimizer.py#L488-L493). Both diagrams show an accepted step. All hooks shown belong to the same FT container. Before, with the base `step()` already wrapped: ```text Trainer.train_step() `-- TorchFTOptimizersContainer.step() |-- pre_hook #1 |-- OptimizerWrapper.step() | |-- manager.should_commit() -> True | `-- TorchFTOptimizersContainer.step() (same container) | |-- pre_hook #2 | |-- super().step() | | |-- pre_hook #3 | | |-- optimizer update loop (once) | | `-- post_hook #1 | `-- post_hook #2 `-- post_hook #3 ``` <img width="1136" height="896" alt="screenshot_before" src="https://github.com/user-attachments/assets/b843dac7-2e4d-420c-935b-a9d15a0ba930" /> Keep a single public `step()` hook boundary, move optimizer updates into `_step_optimizers()`, and call the FT Manager directly. This also removes the temporary dispatch flag, which could remain disabled after an exception. After: ```text Trainer.train_step() `-- OptimizersContainer.step() (inherited public entry) |-- pre_hook #1 |-- TorchFTOptimizersContainer._step_optimizers() | |-- manager.should_commit() -> True | `-- OptimizersContainer._step_optimizers() | `-- optimizer update loop (once) `-- post_hook #1 ``` Validation: - Two-rank Gloo regression with real MoE hooks and collectives: three load synchronizations per rank before the change, one afterward; Manager decisions are mocked. - CPU validation: **48 passed, 1 failed** [torchtitan-test.log](https://github.com/user-attachments/files/32060730/torchtitan-test.log) > The single failure is a pre-existing LR restoration issue: restored optimizers use `[0.05, 0.1]` instead of `[0.0875, 0.175]`, producing a different next update. The same failure reproduces before and after this change. --------- Co-authored-by: jojoinfra <jojobugfree@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps transformers from 4.57.1 to 5.3.0.
Release notes
Sourced from transformers's releases.
... (truncated)
Commits
aad13b8v5.3.0f6c63a6protect imports (#44437)fd6bc38[vllm + v5 fix] handle TokenizersBackend fallback properly for v5 (#44255)30c4801Fix CLI NameError: name 'TypeAdapter' is not defined (#44256)ee4c220Enforce min length in some generate tests (#44401)a4f3df0[tiny] Add olmo_hybrid to tokenizer auto-mapping (#44416)1313588Update PR template (#44415)7235d44Add eurobert (#39455)f60c4e9Add Qwen3.5 support for sequence classification (#44406)fa7f4b6update the expected output for qwen2_5_vl w/ pytorch 2.10 XPU (#44426)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.