Repository navigation
Conversation
Move all the CI detection logic into one place (used to be in 3), add a couple more CI providers to the detection list.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Automated review A maintainer will still review this — treat the notes below as a starting point. 📌 Commit This PR consolidates CI detection in the CDK CLI toolchain: it relocates 🔴 0 blocking · 🟡 0 recommended · ⚪ 1 optional Files with findings (1)
Generated automatically. React 👍 or 👎 to tell us whether this review helped, so we can improve these reviews. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2103 +/- ##
==========================================
- Coverage 92.08% 92.00% -0.08%
==========================================
Files 83 81 -2
Lines 13246 13153 -93
Branches 1886 1875 -11
==========================================
- Hits 12197 12101 -96
- Misses 1011 1014 +3
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
9pace
left a comment
There was a problem hiding this comment.
This also changes the behavior of the ci detection such that now we will automatically do --ci behavior if a ci env var is detected, whereas before the detection only impacted telemetry.
could you clarify if this is the intent of the PR?
Move all the CI detection logic into one place (used to be in 3), add a couple more CI providers to the detection list.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license