Repository navigation
chore: avoid some pointless releases - #2110
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
|
Automated review A maintainer will still review this — treat the notes below as a starting point. 📌 Commit This chore reduces pointless package releases in the CDK Toolkit monorepo. The 🔴 0 blocking · 🟡 0 recommended · ⚪ 1 optional Files with findings (1)
Generated automatically. React 👍 or 👎 to tell us whether this review helped, so we can improve these reviews. |
There was a problem hiding this comment.
See the review summary comment for the overview; the notes below are inline.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2110 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 83 83
Lines 13246 13246
Branches 1886 1886
=======================================
Hits 12197 12197
Misses 1011 1011
Partials 38 38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
On release, we check for every package if a new release should be made. We do this by checking if any new
featorfixcommits have been made in the package itself or any of it declared dependencies. By design, this is nothing but a crude approximation. But so far has been mostly good enough.We've now discovered an edge case where sometimes unrelated files can change as part of a
featorfix(likely unintentionally) and thus causing a release where it shouldn't. This PR fixes that by excluding these patterns.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license