Skip to content

chore: avoid some pointless releases - #2110

Merged
aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore/avoid-pointless-releases
Oct 30, 2026
Merged

aws-cdk-automation merged 1 commit into
mainfrom
mrgrain/chore/avoid-pointless-releases

Conversation

@mrgrain

@mrgrain mrgrain commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

On release, we check for every package if a new release should be made. We do this by checking if any new feat or fix commits have been made in the package itself or any of it declared dependencies. By design, this is nothing but a crude approximation. But so far has been mostly good enough.

We've now discovered an edge case where sometimes unrelated files can change as part of a feat or fix (likely unintentionally) and thus causing a release where it shouldn't. This PR fixes that by excluding these patterns.

Checklist

  • This change contains a major version upgrade for a dependency and I confirm all breaking changes are addressed
    • Release notes for the new version:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Oct 30, 2026
@mrgrain
mrgrain requested a review from a team as a code owner October 30, 2026 12:24
@mrgrain
mrgrain deployed to automation October 30, 2026 12:24 — with GitHub Actions Active
@github-actions github-actions Bot added the p2 label Oct 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@maintainer-for-aws

Copy link
Copy Markdown

Automated review

A maintainer will still review this — treat the notes below as a starting point.

📌 Commit 3ed8e85

This chore reduces pointless package releases in the CDK Toolkit monorepo. The releasable-commits check scans git history for feat/fix commits under a package and its dependencies; when such a commit only touches meta/generated files it still cuts a needless release. The fix adds a global set of git pathspec exclusions (:!THIRD_PARTY_LICENSES, :!.github, :!.projen) in .projenrc.ts, and the six regenerated .projen/tasks.json files carry the matching mechanical edit, consistently and in sync with the source. The change is release-automation plumbing only and touches no shipped CDK code or runtime behavior; it is low-risk. One minor observation: the :!.github exclusion resolves to a non-existent package-local path and is effectively a no-op, noted inline.

🔴 0 blocking · 🟡 0 recommended · ⚪ 1 optional

Files with findings (1)
File Findings
.projenrc.ts ⚪ 1

Generated automatically. React 👍 or 👎 to tell us whether this review helped, so we can improve these reviews.

@maintainer-for-aws maintainer-for-aws Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the review summary comment for the overview; the notes below are inline.

Comment thread .projenrc.ts Resolved
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.08%. Comparing base (fee6951) to head (3ed8e85).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2110   +/-   ##
=======================================
  Coverage   92.08%   92.08%           
=======================================
  Files          83       83           
  Lines       13246    13246           
  Branches     1886     1886           
=======================================
  Hits        12197    12197           
  Misses       1011     1011           
  Partials       38       38           
Flag Coverage Δ
suite.unit 92.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mrgrain mrgrain changed the title chore: avoid pointless releases chore: avoid some pointless releases Oct 30, 2026
@aws-cdk-automation
aws-cdk-automation added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 3f9ca1c Oct 30, 2026
40 checks passed
@aws-cdk-automation
aws-cdk-automation deleted the mrgrain/chore/avoid-pointless-releases branch October 30, 2026 13:36

This branch was successfully deployed

1 active deployment
automation — 3ed8e851 Deployed Oct 30, 2026 by mrgrain via Set AutoQueue on PR #2110 #3898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p2 pr/exempt-integ-test Skips the integ test steps if set.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants