Repository navigation
fix(test-server): sort the raw AES wrapping AAD by UTF-8 bytes - #1719
Merged
lucasmcdonald3 merged 2 commits intoOct 29, 2026
Merged
lucasmcdonald3 merged 2 commits into
lucasmcdonald3 merged 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Build the test server's raw AES keyring with
utf8Sorting: true.The raw AES keyring defaults to sorting the encryption context in locale order when it builds the wrapping AAD, so it disagrees with every other ESDK whenever a key sorts differently in locale and UTF-8 byte order (e.g.
\u00a0, oraws-crypto-public-keynext to\u0100).JS's own cross-language vector runner (
integration-node) already setsutf8Sorting: true.Raw AES between JS and any other server, with such an encryption context
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: