Skip to content

fix(ci): show real current version in duplicate-deps error message #955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lucasmcdonald3 wants to merge 2 commits into
base: mainline
Choose a base branch
from
+5 −3
Open

fix(ci): show real current version in duplicate-deps error message #955

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0252e7
fix(ci): show real current version in duplicate-deps error message
Sep 1, 2026
525ed0f
fix(rust): pin aws-lc-sys to 0.45.0 to match aws-lc-rs
Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/rust_duplicate_deps.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,8 +101,10 @@ jobs:
# Repo-relative path to the offending Cargo.toml, and the line to change.
cargo_path="$dir/Cargo.toml"
cargo_line=$(grep -nE "^$crate[[:space:]]*=" Cargo.toml | head -1)
cur=$(printf '%s' "$cargo_line" | grep -oE '[0-9][0-9.]+' | head -1)
lineno=$(printf '%s' "$cargo_line" | cut -d: -f1)
# Strip grep -n's "N:" line-number prefix before reading the
# version, otherwise the line number is misread as the version.
cur=$(printf '%s' "${cargo_line#*:}" | grep -oE '[0-9][0-9.]+' | head -1)

echo "::error::$crate versions aren't consistent. Fix: pin it to $want in $cargo_path."
echo "In $cargo_path line $lineno, change"
Expand Down
2 changes: 1 addition & 1 deletion AwsEncryptionSDK/runtimes/rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ readme = "README.md"
[dependencies]
aws-config = "1.8.12"
aws-lc-rs = {version = "1.18.0"}
aws-lc-sys = { version = "0.44", optional = true }
aws-lc-sys = { version = "0.45.0", optional = true }
aws-lc-fips-sys = { version = "0.14.1", optional = true }
aws-sdk-dynamodb = "1.103.0"
aws-sdk-kms = "1.98.0"
Expand Down
2 changes: 1 addition & 1 deletion TestVectors/runtimes/rust/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ readme = "README.md"
[dependencies]
aws-config = "1.8.12"
aws-lc-rs = {version = "1.18.0"}
aws-lc-sys = { version = "0.44", optional = true }
aws-lc-sys = { version = "0.45.0", optional = true }
aws-lc-fips-sys = { version = "0.14.1", optional = true }
aws-sdk-dynamodb = "1.103.0"
aws-sdk-kms = "1.98.0"
Expand Down
Loading