[Test] Add end2end test to validate tutotial for the upgrade of nvidia software stack. - #7500
Open
gmarciani wants to merge 5 commits into
Open
[Test] Add end2end test to validate tutotial for the upgrade of nvidia software stack.#7500gmarciani wants to merge 5 commits into
gmarciani wants to merge 5 commits into
Conversation
gmarciani
changed the title
gmarciani
added
skip-changelog-update
gmarciani
force-pushed
the
wip/mgiacomo/3160/test-upgrade-nvidia-0722-1
branch
from
July 22, 2026 22:44
752dbe4 to
2f5d944
Compare
gmarciani
marked this pull request as ready for review
July 24, 2026 15:22
gmarciani
force-pushed
the
wip/mgiacomo/3160/test-upgrade-nvidia-0722-1
branch
from
July 29, 2026 20:22
2f5d944 to
8683840
Compare
…a software stack.
… test_patching use the common function to execute GPU workload.
…a software stack.
…1.05 and CUDA 13.2.2.
gmarciani
force-pushed
the
wip/mgiacomo/3160/test-upgrade-nvidia-0722-1
branch
from
July 29, 2026 21:01
107b52c to
902faea
Compare
hehe7318
reviewed
Jul 30, 2026
|
|
||
| # NVLSM is versioned independently of the driver and is not pinned in the component: the component | ||
| # installs the version bundled in the NVIDIA driver local repository for NVIDIA_DRIVER_VERSION | ||
| # (2025.10.14 is the version bundled in the 580.173.02 driver local repository). |
Contributor
There was a problem hiding this comment.
Why get it from 580.173.02 rather than 595?
hehe7318
reviewed
Jul 30, 2026
| # NVLSM is versioned independently of the driver and is not pinned in the component: the component | ||
| # installs the version bundled in the NVIDIA driver local repository for NVIDIA_DRIVER_VERSION | ||
| # (2025.10.14 is the version bundled in the 580.173.02 driver local repository). | ||
| NVLSM_BUNDLED_VERSION = "2025.10.14" |
Contributor
There was a problem hiding this comment.
If the above comment is correct, then the is_equal_to assertion will fail. Please double check it.
hehe7318
reviewed
Jul 30, 2026
| def _wait_for_build_image_complete(image): | ||
| """Wait for the image build to complete and assert it succeeded.""" | ||
| logging.info("Waiting for build of image %s to complete", image.image_id) | ||
| while image.image_status.endswith("_IN_PROGRESS"): # e.g. BUILD_IN_PROGRESS |
Contributor
There was a problem hiding this comment.
[Block] This while loop doesn't have a timeout, if the AMI build hang, it will stuck forever.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Add end2end test to validate tutotial for the upgrade of nvidia software stack.
Also, remove code duplication by making 3 tests use a common function to validate gpu workload.
Tests
ONGOING
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.