Repository navigation
fix(dynamodb): split read_items keys into BatchGetItem requests of at most 100 - #3518
Merged
kukushking merged 2 commits intoOct 25, 2026
Merged
Conversation
… most 100 Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
kukushking
force-pushed
the
fix/dynamodb-read-items-over-100-keys
branch
from
October 25, 2026 00:25
72f86dd to
00e45e0
Compare
kukushking
approved these changes
Oct 25, 2026
Collaborator
|
Thanks @sebxt ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or Bugfix
Detail
wr.dynamodb.read_itemssent allpartition_valuesin oneBatchGetItemrequest. DynamoDB rejects requests with more than 100 keys, so reading 101 or more keys raised aValidationException._read_batch_items_chunkednow sends the keys in slices of 100 and handlesUnprocessedKeysfor each slice, yielding one chunk per response as before.test_dynamodb_read_items_more_than_100_partition_valuesintests/unit/test_moto.py(chunked and non chunked). It fails on main with theValidationExceptionand passes with the fix.tests/unit/test_moto.py,test_utils.py,test_metadata.py,test_session.py,test_data_quality_rules.pyandtest_bedrock_mocked.pypass locally;ruff format --check,ruff checkandmypy awswranglerreport nothing new.Relates
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.