Make neptune-export cross-platform by removing hardcoded line and path separators#202
Make neptune-export cross-platform by removing hardcoded line and path separators#202drossi750 wants to merge 4 commits into
Conversation
…h separators Signed-off-by: Rossi, Davide <Davide.Rossi@hilti.com>
…p_print Task/handle nested properties map print
|
@triggan Can you take a quick look at this one? |
|
|
||
| CsvPrinterOptions csvPrinterOptions = CsvPrinterOptions.builder().setIncludeTypeDefinitions(includeTypeDefinitions).build(); | ||
| JsonPrinterOptions jsonPrinterOptions = JsonPrinterOptions.builder().setStrictCardinality(true).build(); | ||
| JsonPrinterOptions jsonPrinterOptions = JsonPrinterOptions.builder().setStrictCardinality(strictCardinality).build(); |
There was a problem hiding this comment.
This is a change to the default behavior of setStrictCardinality(true). Instead of changing the default behavior, can we leave strictCardinality as true and change the parameter to accept --strict-cardinality false instead?
|
I took a look at the committed changes. Everything looks good except for the change in default behavior for JSON formatting for properties with single values. I think adding the ability to remove the square brackets for properties with single properties makes sense and is needed, but we likely need to make that a configurable change versus changing that to be the default. This thinking is based on the fact that neptune-export is a dependency for many other workloads at this point. |
|
Moving this PR over to the official neptune-export repo along with some other considerations. aws/neptune-export#193 |
3 participants
Make neptune-export cross-platform by removing hardcoded line and path separators
Signed-off-by: Rossi, Davide Davide.Rossi@hilti.com
Issue #, if available:
Description of changes:
Even though this would run in a linux-like environment like a lambda, developing and running on a Windows machine yields failing tests. There is no change in the behavior of the application, just making sure that the same execution on different OS leads to the same result.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.