Skip to content

fix: correct log, Javadoc, and documentation grammar in SES and SQS #1623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Baqirrizvidev wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: correct log, Javadoc, and documentation grammar in SES and SQS #1623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/ses.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ class MailSendingService {

Sending attachments with e-mail or HTML e-mails requires MIME messages to be created and sent. In order to create MIME messages,
the Java Mail API dependency and an implementation need to be in the classpath. Spring Cloud AWS will detect the
dependency and create a `org.springframework.mail.javamail.JavaMailSender` implementation that allows to create and
dependency and create a `org.springframework.mail.javamail.JavaMailSender` implementation that allows you to create and
build MIME messages and send them. Dependencies for the Java Mail API and an implementation are the only needed configuration changes as shown below.

[source,xml,indent=0]
Expand Down
2 changes: 1 addition & 1 deletion docs/src/main/asciidoc/sqs.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1259,7 +1259,7 @@ MessageListenerContainer<Object> listenerContainer(SqsAsyncClient sqsAsyncClient
}
----

NOTE: The `SqsMessageListenerContainer.builder()` allows to specify the `SmartLifecycle.phase`, to override the default value defined in `MessageListenerContainer.DEFAULT_PHASE`
NOTE: The `SqsMessageListenerContainer.builder()` allows you to specify the `SmartLifecycle.phase`, to override the default value defined in `MessageListenerContainer.DEFAULT_PHASE`

===== Retrieving Containers from the Registry

Expand Down
2 changes: 1 addition & 1 deletion ...g-cloud-aws-ses/src/main/java/io/awspring/cloud/ses/SimpleEmailServiceJavaMailSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
import software.amazon.awssdk.services.ses.model.SendRawEmailResponse;

/**
* {@link JavaMailSender} implementation that allows to send {@link MimeMessage} using the Simple E-Mail Service. In
* {@link JavaMailSender} implementation that allows sending {@link MimeMessage} using the Simple E-Mail Service. In
* contrast to {@link SimpleEmailServiceMailSender} this class also allows the use of attachment and other mime parts
* inside mail messages.
*
Expand Down
2 changes: 1 addition & 1 deletion spring-cloud-aws-ses/src/main/java/io/awspring/cloud/ses/SimpleEmailServiceMailSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ public void send(SimpleMailMessage... simpleMessages) throws MailException {
try {
SendEmailResponse sendEmailResult = getEmailService().sendEmail(prepareMessage(simpleMessage));
if (LOGGER.isDebugEnabled()) {
LOGGER.debug("Message with id: {} successfully send", sendEmailResult.messageId());
LOGGER.debug("Message with id: {} successfully sent", sendEmailResult.messageId());
}
}
catch (SesException e) {
Expand Down