Skip to content

refactor(sns): modernize stream collector in SnsBatchTemplate #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Baqirrizvidev wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −3
Open

refactor(sns): modernize stream collector in SnsBatchTemplate #1630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions spring-cloud-aws-sns/src/main/java/io/awspring/cloud/sns/core/batch/SnsBatchTemplate.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
import io.awspring.cloud.sns.core.batch.converter.SnsMessageConverter;
import io.awspring.cloud.sns.core.batch.executor.BatchExecutionStrategy;
import java.util.Collection;
import java.util.stream.Collectors;
import org.springframework.messaging.Message;
import org.springframework.messaging.support.MessageBuilder;
import org.springframework.util.Assert;
Expand Down Expand Up @@ -81,7 +80,7 @@ public <T> BatchResult convertAndSend(String topicName, Collection<T> payloads)
Assert.notNull(topicName, "topicName is required");
Assert.notNull(payloads, "payloads are required");
var batchList = payloads.stream().map(it -> MessageBuilder.withPayload(it).build())
.map(snsMessageConverter::convertMessage).collect(Collectors.toList());
.map(snsMessageConverter::convertMessage).toList();
return batchExecutionStrategy.send(topicArnResolver.resolveTopicArn(topicName), batchList);
}

Expand All @@ -100,7 +99,7 @@ public <T> BatchResult sendBatchNotifications(String topicName, Collection<SnsNo
Assert.notNull(notifications, "notifications are required");
var batchList = notifications.stream()
.map(it -> MessageBuilder.withPayload(it.getPayload()).copyHeaders(it.getHeaders()).build())
.map(snsMessageConverter::convertMessage).collect(Collectors.toList());
.map(snsMessageConverter::convertMessage).toList();
return batchExecutionStrategy.send(topicArnResolver.resolveTopicArn(topicName), batchList);
}

Expand Down