Repository navigation
fix missing type in the media of rich message blocks - #339
Merged
Merged
Conversation
Sending a rich message with a media block fails with:
Bad Request: can't parse InputRichBlock: Can't find field "type"
InputRichBlockVideo holds an InputMediaVideo, and that struct has no type field
of its own - it normally gets one from the InputMedia enum tag. Inside a block
there is no tag, so the media goes out without a type and Telegram rejects it.
Same for the photo, animation, audio, voice note and document blocks.
Fixed with a serialize_with that writes the type next to the flattened media.
Public API and deserialization are unchanged.
Collaborator
|
Why not something with https://serde.rs/enum-representations.html#internally-tagged ? This looks overly complex currently with the additional module needed and having that as an enum seems like a better solution? 🤔 |
Owner
|
@mmahdi-sz what do you think about @EdJoPaTo 's suggestion? |
Contributor
Author
|
Serde's That's why #340 went with the exact same I improved my PR and pushed an update to cover all 6 media types in the tests. |
Owner
|
thank you! merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sending a rich message with a media block fails with:
InputRichBlockVideoholds anInputMediaVideo, and that struct has notypefield of its own - it normally gets one from theInputMediaenum tag. Inside a block there is no tag, so the media goes out without a type and Telegram rejects it. Same for the photo, animation, audio, voice note and document blocks.Fixed with a
serialize_withthat writes the type next to the flattened media. Public API and deserialization are unchanged.