Skip to content

A11y: high-confidence round2 semantic cleanup #5644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
accesswatch wants to merge 4 commits into
base: main
Choose a base branch
from
Open

A11y: high-confidence round2 semantic cleanup #5644

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d4cc4b
Apply high-confidence round2 navigation semantics fixes
accesswatch May 28, 2026
c52c9d4
Stabilize composer audit check for abandoned packages
accesswatch May 28, 2026
aa79788
Merge origin/main; drop CI composer audit changes (handled in #5657)
accesswatch Aug 7, 2026
d4acab1
Merge origin/main
accesswatch Aug 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions modules/custom/az_core/src/Plugin/Block/MobileNavBlock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ public function build() {
],
),
'#attributes' => [
'type' => 'button',
'class' => [
'use-ajax',
'ps-0',
Expand Down Expand Up @@ -343,7 +342,6 @@ public function build() {
$build['az_mobile_nav_menu']['heading_div']['heading'] = [
'#type' => 'link',
'#attributes' => [
'role' => 'button',
'class' => [
'px-3',
'text-blue',
Expand Down Expand Up @@ -382,7 +380,6 @@ public function build() {
$pageLink = [
'#type' => 'link',
'#attributes' => [
'role' => 'button',
'class' => [
'nav-link',
$isMainMenu ? 'ms-2' : 'ms-3',
Expand All @@ -407,7 +404,6 @@ public function build() {
],
),
'#attributes' => [
'type' => 'button',
'class' => [
'use-ajax',
'btn',
Expand Down
2 changes: 0 additions & 2 deletions modules/custom/az_select_menu/src/Plugin/Block/AzSelectMenu.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,9 +161,7 @@ public function build() {
'disabled',
],
'aria-disabled' => 'true',
'role' => 'button',
'type' => 'button',
'tabindex' => '0',
]);

$build['#button_attributes'] = $button_attributes;
Expand Down
8 changes: 4 additions & 4 deletions themes/custom/az_barrio/templates/layout/page.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,26 +109,26 @@
{% if page.navigation_offcanvas %}
<div class="d-lg-none d-flex col-auto px-0">
{% if page.navigation_offcanvas.az_barrio_offcanvas_searchform %}
<button type="button" data-bs-toggle="offcanvas" data-bs-target="#azMobileNav" aria-controls="azMobileNav" class="btn btn-arizona-header" id="jsAzSearch">
<button type="button" data-bs-toggle="offcanvas" data-bs-target="#azMobileNav" aria-controls="azMobileNav" aria-label="{{ 'Open search panel'|t }}" class="btn btn-arizona-header" id="jsAzSearch">
<span aria-hidden="true" class="icon material-symbols-rounded">search</span>
<span class="icon-text">Search</span>
</button>
{% endif %}
{% for offcanvasblock in page.navigation_offcanvas %}
{% if 'mobile_nav_block' in offcanvasblock['#cache']['keys'] %}
<button type="button" data-bs-toggle="offcanvas" data-bs-target="#azMobileNav" aria-controls="azMobileNav" class="btn btn-arizona-header">
<button type="button" data-bs-toggle="offcanvas" data-bs-target="#azMobileNav" aria-controls="azMobileNav" aria-label="{{ 'Open menu panel'|t }}" class="btn btn-arizona-header">
<span aria-hidden="true" class="icon material-symbols-rounded">menu</span>
<span class="icon-text">Menu</span>
</button>
{% endif %}
{% endfor %}
<div class="offcanvas offcanvas-end mw-100 w-100 bg-white d-flex d-lg-none overflow-y-auto" tabindex="-1" id="azMobileNav" aria-label="Mobile navigation">
<div class="offcanvas-header sticky-top p-0 mb-2 {{ az_header_blue ? 'text-bg-blue' : 'text-bg-red' }} text-bg-red d-flex justify-content-between align-items-center">
<a href="/" class="btn btn-arizona-header">
<a href="/" aria-label="{{ 'Go to homepage'|t }}" class="btn btn-arizona-header">
<span aria-hidden="true" class="icon material-symbols-rounded">home</span>
<span class="icon-text">Home</span>
</a>
<button type="button" data-bs-toggle="offcanvas" data-bs-target="#azMobileNav" aria-controls="azMobileNav" class="btn btn-arizona-header">
<button type="button" data-bs-toggle="offcanvas" data-bs-target="#azMobileNav" aria-controls="azMobileNav" aria-label="{{ 'Close menu panel'|t }}" class="btn btn-arizona-header">
Comment on lines +107 to +126
<span aria-hidden="true" class="icon material-symbols-rounded">close</span>
<span class="icon-text">Close</span>
</button>
Expand Down
2 changes: 1 addition & 1 deletion themes/custom/az_barrio/templates/navigation/breadcrumb.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#}

{% if breadcrumb %}
<nav role="navigation" aria-label="breadcrumb">
<nav role="navigation" aria-label="{{ 'Breadcrumb'|t }}">
<ol class="breadcrumb">
{% for item in breadcrumb %}
{% if item.url %}
Expand Down
Loading