refactor(pxe): migrate PrivateEventStore to BaseStagingStore - #110
Open
nchamo wants to merge 2 commits into
Open
refactor(pxe): migrate PrivateEventStore to BaseStagingStore#110nchamo wants to merge 2 commits into
nchamo wants to merge 2 commits into
Conversation
nchamo
added
ci-draft
nchamo
marked this pull request as ready for review
August 28, 2026 19:58
nchamo
force-pushed
the
nchamo/private-event-store-base-staging
branch
from
August 28, 2026 20:04
14ce305 to
3e2d9de
Compare
nventuro
force-pushed
the
nchamo/private-event-store-base-staging
branch
from
August 28, 2026 21:17
3e2d9de to
21d7d81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PrivateEventStoreontoBaseStagingStore(fix(pxe): per-change-set staging store that rejects dead change sets #47): the per-change-set maps, locks,commitChangeSet/discardChangeSetand the rollback guard now come from the base class, leavingflushChangeSetandapplyRollback.getPrivateEventstakes achangeSetIdand layers staged events over the committed index, andPXE.getPrivateEventsreads inside itsrunSyncedblock rather than after the commit. Same events either way: the sync that produces them stages them under that change set.eventIdsAtBlock, which had no production callers, as fix(pxe): per-change-set staging store that rejects dead change sets #47 did forNoteStore.nullifiersOfNotesAtBlock.StagedWriteCoordinator's registry, soStagedStore.beginChangeSetis now required, resolving its TODO.Stacked on #108.