bugfix: fix potential thread-safety issue in BacktraceLogManager - #296
Merged
Conversation
Merged
melekr
approved these changes
Jul 9, 2026
melekr
left a comment
Collaborator
There was a problem hiding this comment.
Non-blocking: the lock scope could be narrowed to only the ToArray() copy, then build the StringBuilder after releasing the lock. Still looks good given the small default log count, but the narrower scope would be cleaner.
melekr
marked this pull request as ready for review
July 9, 2026 20:52
Contributor
Author
Good idea, I've narrowed the lock's scope. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ToSourceCode()reads the log queue without the lock thatEnqueue()/Dequeue()use, so a concurrent log from a background thread could corrupt the read. This makes the manager thread-safe on its own instead of relying on the caller to lock.Changes
BacktraceLogManager: Wrap theLogQueueread inToSourceCode()withlockObject.ref: BT-7318