Keep an unsent message as a draft while switching rooms - #283
Merged
Merged
Conversation
The composer stores what's being written in localStorage per room and restores it when the room is opened again. Sending clears it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hopping between rooms lost whatever was being typed in the composer. The composer now saves the editor content to localStorage on every change, keyed by room, restores it when the room is opened again, and clears it once the message is sent.
The draft is per room, not per user, so two accounts sharing a browser profile would see each other's unsent drafts.
System test covers writing in two rooms, switching between them, sending one, and finding the other still there.