Conversation
The fixture calls BCrypt directly, bypassing Rails' test configuration.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approved
The focused change is valid, consistent with existing development setup, and introduces no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Uses bcrypt’s minimum cost for fixture passwords, significantly speeding up test setup while preserving authentication behavior.
Changes:
- Configures fixture password hashing with
BCrypt::Engine::MIN_COST.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
test/fixtures/users.yml |
Reduces bcrypt cost for test fixture password generation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixtures call
BCryptdirectly, bypassingRailstest configuration.Switching to
MIN_COSTsignificantly reduces test run time:before
after