Skip to content

Add example failing test with canImport #1738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
keith wants to merge 1 commit into
base: main
Choose a base branch
from
+28 −0
Draft

Add example failing test with canImport #1738

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions test/fixtures/precompiled_modules/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,25 @@ transition_test(
],
)

swift_library(
name = "can_import_undeclared_sdk_module",
srcs = ["can_import_undeclared_sdk_module.swift"],
tags = FIXTURE_TAGS,
target_compatible_with = ["@platforms//os:macos"],
deps = ["@system_sdk//:Foundation"],
)

transition_binary(
name = "can_import_undeclared_sdk_module_transitioned",
tags = FIXTURE_TAGS,
target = ":can_import_undeclared_sdk_module",
transitive_features = [
"swift.use_c_modules",
"swift.emit_c_module",
"-swift.add_default_precompiled_modules",
],
)

cross_platform_targets(tags = FIXTURE_TAGS)

swift_import(
Expand Down
8 changes: 8 additions & 0 deletions test/fixtures/precompiled_modules/can_import_undeclared_sdk_module.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#if canImport(SwiftUI)
// #error("should this be false if the dep is missing?")
import SwiftUI
#endif

public struct CanImportUndeclaredSDKModule {
public init() {}
}
1 change: 1 addition & 0 deletions test/precompiled_modules_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,7 @@ def precompiled_modules_test_suite(name, tags = []):
name = "{}_build_test".format(name),
targets = [
"//test/fixtures/precompiled_modules:application_extension_unavailable_transitioned",
"//test/fixtures/precompiled_modules:can_import_undeclared_sdk_module_transitioned",
"//test/fixtures/precompiled_modules:foundation_requires_explicit_dep_transitioned",
"//test/fixtures/precompiled_modules:hello",
"//test/fixtures/precompiled_modules:hello_with_explicit_deps_transitioned",
Expand Down