Skip to content

HFI Calc Admin tweak#5576

Merged
brettedw merged 7 commits into
mainfrom
task/hfi-calc-admin
Jul 2, 2026
Merged

HFI Calc Admin tweak#5576
brettedw merged 7 commits into
mainfrom
task/hfi-calc-admin

Conversation

@brettedw

@brettedw brettedw commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator
  • Use planning area + station code as the stable identity for station removals
  • Include station code in removed-station API payloads
  • Keep the station admin modal open until save succeeds
  • Show station update failures inside the modal
  • Clear station update errors on retry
  • Format FastAPI validation error arrays into readable messages

Test Links:

Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch
Weather Toolkit

@codecov

codecov Bot commented Jun 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 65.38462% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.26%. Comparing base (4a4659d) to head (823491a).

Files with missing lines Patch % Lines
...lator/components/stationAdmin/StationListAdmin.tsx 52.63% 7 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5576      +/-   ##
==========================================
+ Coverage   67.05%   67.26%   +0.21%     
==========================================
  Files         382      382              
  Lines       22686    22688       +2     
  Branches     3101     3107       +6     
==========================================
+ Hits        15211    15262      +51     
+ Misses       6311     6256      -55     
- Partials     1164     1170       +6     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brettedw brettedw requested a review from conbrad June 29, 2026 23:28
Comment thread web/apps/wps-web/src/features/hfiCalculator/slices/hfiCalculatorSlice.ts Outdated
Comment thread web/apps/wps-web/src/features/hfiCalculator/slices/hfiCalculatorSlice.ts Outdated
@brettedw brettedw requested a review from conbrad June 30, 2026 22:40
@sonarqubecloud

sonarqubecloud Bot commented Jul 2, 2026

Copy link
Copy Markdown

@conbrad conbrad left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@brettedw brettedw deployed to production July 2, 2026 17:28 Active
@brettedw brettedw merged commit a355861 into main Jul 2, 2026
42 of 45 checks passed
@brettedw brettedw deleted the task/hfi-calc-admin branch July 2, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants