Skip to content

Inject pageUrl into page vars automatically #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcomnes wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Inject pageUrl into page vars automatically #250

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
39e9c72
Inject pageUrl into page vars automatically
bcomnes Apr 18, 2026
cd323d7
Fix pageUrl for loose markdown pages and Windows path separators
bcomnes Apr 18, 2026
10a9284
Extract computePageUrl helper and add unit tests for URL derivation r…
bcomnes Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions lib/build-pages/page-data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

import { resolveVars, resolvePostVars } from './resolve-vars.js'
import { pageBuilders } from './page-builders/index.js'
import { fsPathToUrlPath } from './page-builders/fs-path-to-url.js'
// @ts-expect-error
import pretty from 'pretty'

Expand Down Expand Up @@ -141,6 +142,7 @@ export class PageData {
const { globalVars, globalDataVars, pageVars, builderVars } = this
// @ts-ignore
return {
Copy link
Copy Markdown
Owner Author

@bcomnes bcomnes Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we get rid of this?

pageUrl: this.#computePageUrl(),
Copy link
Copy Markdown
Owner Author

@bcomnes bcomnes Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a method?

...globalVars,
...globalDataVars,
...pageVars,
Expand All @@ -156,6 +158,19 @@ export class PageData {
return this.workerFiles
}

/**
* Derive the canonical URL path for this page from its filesystem path and output name.
* Index pages get a trailing-slash URL; other outputs include the filename.
* @return {string}
*/
#computePageUrl () {
const { path, outputName } = this.pageInfo
if (outputName === 'index.html') {
return path ? fsPathToUrlPath(path) + '/' : '/'
}
return path ? fsPathToUrlPath(path) + '/' + outputName : '/' + outputName
Comment thread
bcomnes marked this conversation as resolved.
Outdated
}

/**
* [init description]
* @param {object} params - Parameters required to initialize
Expand Down