Skip to content

Resolve copy paths relative to src in DomStack constructor #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bcomnes wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Resolve copy paths relative to src in DomStack constructor #251

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4dd014e
Resolve copy paths relative to src in DomStack constructor
bcomnes Apr 18, 2026
c0ca6d6
Use process.cwd() as base for relative copy paths, matching the CLI
bcomnes Apr 18, 2026
8eb2c0a
Add unit tests for DomStack constructor copy path resolution
bcomnes Apr 18, 2026
d89abf5
Use cross-platform temp paths and path.resolve() in copy path tests
bcomnes Apr 19, 2026
fce6532
fix: cast array index access to satisfy noUncheckedIndexedAccess in tsc
bcomnes Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,12 @@ export class DomStack {
this.#src = src
this.#dest = dest

const copyDirs = opts?.copy ?? []
const basedir = dirname(resolve(src))
const copyDirs = (opts?.copy ?? []).map(dir => resolve(basedir, dir))

Comment thread
bcomnes marked this conversation as resolved.
Outdated
this.opts = {
...opts,
copy: copyDirs,
Comment thread
bcomnes marked this conversation as resolved.
Outdated
ignore: [
...DEFAULT_IGNORES,
basename(dest),
Expand All @@ -172,12 +174,11 @@ export class DomStack {
],
}

if (copyDirs && copyDirs.length > 0) {
if (copyDirs.length > 0) {
const absDest = resolve(this.#dest)
for (const copyDir of copyDirs) {
// Copy dirs can be in the src dir (nested builds), but not in the dest dir.
const absCopyDir = resolve(copyDir)
const relToDest = relative(absDest, absCopyDir)
const relToDest = relative(absDest, copyDir)
if (relToDest === '' || !relToDest.startsWith('..')) {
throw new Error(`copyDir ${copyDir} is within the dest directory`)
}
Expand Down