Skip to content

Chore/release - #7

Merged
tnkshuuhei merged 6 commits into
mainfrom
chore/release
Jan 21, 2026
Merged

tnkshuuhei merged 6 commits into
mainfrom
chore/release

Conversation

@tnkshuuhei

@tnkshuuhei tnkshuuhei commented Jan 21, 2026 •

Copy link
Copy Markdown
Member

@claude

claude Bot commented Jan 21, 2026

Copy link
Copy Markdown

Code review

I've found 2 issues that need to be addressed:

1. Node.js version conflicts with CLAUDE.md documentation

File: .github/workflows/release.yml line 24

The PR changes Node.js from version 22 to 24, but CLAUDE.md line 106 explicitly documents the runtime as "Bun + Node.js 22.x":

- **Runtime**: Bun + Node.js 22.x

Impact: This creates a documentation inconsistency. If Node.js 24 is required for OIDC support, CLAUDE.md should be updated to reflect the new runtime requirement.

Location:

- name: Setup Node.js
uses: actions/setup-node@v4
with:
node-version: "24"
registry-url: "https://registry.npmjs.org"


2. Missing NODE_AUTH_TOKEN workaround for npm OIDC authentication

File: .github/workflows/release.yml lines 45-46

The PR removes NODE_AUTH_TOKEN to enable OIDC Trusted Publishing, but the changesets/action@v1 has a known bug where it appends undefined to the .npmrc file when NODE_AUTH_TOKEN is not provided, breaking npm authentication.

The issue: See changesets/action#542 and PR #545 - the fix is not yet merged into v1.

Required workaround: Until the fix is released, you need to set NODE_AUTH_TOKEN: '' (empty string) in the env block to prevent the undefined token from being injected.

Suggested fix:

env:
  GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
  NODE_AUTH_TOKEN: ''

Location:

- name: Create Release Pull Request or Publish
id: changesets
uses: changesets/action@v1
with:
publish: npm publish --access public --provenance
version: bunx changeset version
title: "chore: version packages"
commit: "chore: version packages"
createGithubReleases: true
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}


Summary:

  • 1 CLAUDE.md compliance issue (Node.js version documentation)
  • 1 bug (missing npm OIDC workaround)

@tnkshuuhei
tnkshuuhei merged commit 0f319cd into main Jan 21, 2026
1 check passed
@tnkshuuhei
tnkshuuhei deleted the chore/release branch January 21, 2026 10:46
@github-actions github-actions Bot mentioned this pull request Jan 21, 2026
bratsos added a commit to bratsos/polizy that referenced this pull request Jan 29, 2026
Node.js 24 has native support for npm OIDC trusted publishing,
which should resolve the ENEEDAUTH errors when using id-token
permissions with changesets/action.

Ref: beaconlabs-io/evidence#7

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant