Codex/issue 2045 handlebars tr#2448
Open
SarthakDudhe wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #2045, I fixed the HTML beautifier so Handlebars helpers like {{#tr}}...{{/tr}} are no longer mistaken for real HTML table tags during optional end-tag handling.
Description text:
Fixed a table-formatting edge case in the HTML beautifier where Handlebars helpers whose names match HTML table elements, especially {{#tr}}, were being treated like actual tags. In js/src/html/beautifier.js, _do_optional_end_element() now only applies HTML optional-closing rules when the parser token came from a real HTML tag (tag_start_char === '<'). That prevents template tokens from triggering the table-specific pop logic while preserving normal behavior for real HTML markup. I also added a regression case in test/data/html/tests.js as its own issue-specific group with indent_handlebars disabled, so the formatter keeps {{#tr}}translated{{/tr}} correctly nested inside the table cell. I verified the formatter output now stays as expected for the Handlebars helper and that regular table formatting is unchanged.