Codex/issue 2375 custom elements block default#2451
Open
SarthakDudhe wants to merge 10 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #2375 by changing the HTML formatter’s default behavior for dashed custom elements. Those tags are no longer treated as inline unless inline_custom_elements is explicitly turned on, so markup like and now formats as separate block-style lines by default instead of staying glued together on one line. I also kept the old inline behavior available behind inline_custom_elements=true, and updated the docs plus regression tests to cover both modes.
What changed:
Updated the default in js/src/html/options.js from inline_custom_elements: true to false
Updated the CLI docs in README.md to match the new default
Reworked the HTML regression tests in test/data/html/tests.js
Added a default-behavior regression for top-level dashed custom elements
Added a second check showing inline_custom_elements=true still preserves the inline formatting
Verified the generated HTML tests with node test/generate-tests.js