Issue 2381 preserve single newlines#2453
Open
SarthakDudhe wants to merge 12 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one fixes #2381 by preserving single newlines that appear inside parenthesized JavaScript expressions instead of flattening them away.
What changed:
In js/src/javascript/beautifier.js, handle_whitespace_and_comments() now treats a single newline as significant when the formatter is inside an expression and preserve_newlines is enabled.
The same logic was mirrored in python/jsbeautifier/javascript/beautifier.py so the Python formatter stays aligned with the JS implementation.
I added a regression test in test/data/javascript/tests.js for:
foo(bar\nbaz); which now stays split across lines instead of collapsing to foo(bar baz);
foo(bar\n); which remains preserved as-is
The generated Python fixture picked up the same case, but that file is gitignored in this repo so you do not need to stage it.