Issues/2372 cdata handling#2454
Open
SarthakDudhe wants to merge 13 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #2372 by making the JavaScript E4X/XML literal tokenizer treat CDATA as “anything up to the real closing ]]>” instead of stopping at the first ].
What changed:
Updated the XML literal regex in js/src/javascript/tokenizer.js so the CDATA branch now accepts ] characters inside the CDATA body.
Mirrored the same regex change in python/jsbeautifier/javascript/tokenizer.py to keep the Python implementation aligned.
Added a regression test in test/data/javascript/tests.js for:
xml=;
The new test proves the formatter now preserves the XML literal instead of breaking it into invalid markup when ] appears inside CDATA.