Issues/2380 less each indentation#2455
Open
SarthakDudhe wants to merge 14 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #2380 in the web/CSS formatter: LESS each(...) callback blocks were causing the surrounding rule to lose its indentation after the callback closed, so sibling selectors like .after { ... } were being pushed back to the root level. I added a small bit of state in
js/src/css/beautifier.js
and mirrored it in
python/cssbeautifier/css/beautifier.py
so the formatter can tell the difference between a real CSS block and a brace that belongs to a parenthesized LESS mixin callback. That lets each(@set, { ... }); close cleanly without stealing the outer rule’s indentation.