Fix mobile sponsor logo sizing and spacing#116
Merged
Conversation
…ller condensed gold/blue Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A previous attempt to make Gold/Blue sponsor logos smaller and more condensed on mobile had no visible effect. Two root causes:
gap. The mobile grids usedgrid-cols-N+justify-items-center, which creates equal-width columns (each 1/N of the container) with the logo centered inside. The visible space between logos came from the wide columns, so shrinkinggap-xdid almost nothing.max-w/max-hcap, so reducingmax-h-12 → max-h-10was barely noticeable. Separately, Diamond usedmax-h-18, which isn't a real Tailwind class (the default scale skips 18) so it never compiled.Fixes (all in
content/_index.md, mobile only — desktop reverts viasm:and is unchanged):gapis the actual spacing:grid-cols-[repeat(2,auto)]/grid-cols-[repeat(3,auto)]+justify-center.object-containso they actually scale to the requested size (up for Diamond, down for Gold/Blue), e.g.w-32 h-16 object-contain(larger)w-28 h-10 object-contain(smaller) + tightergap-x-4w-20 h-10 object-contain(smaller) + tightergap-x-3[&>a:last-child]:col-span-2 [&>a:last-child]:justify-self-center.Verified at ~390px (mobile) and full width (desktop).
Link to Devin session: https://app.devin.ai/sessions/2c62d21ae9ab454ca4fe0b9e0d559825