fix(tamanu/doctor): external_users only warns, never fails#430
Merged
Conversation
A long-lived interactive session now only ever produces a warning; it no longer flips the overall doctor result to FAILING. Removes the 24h FAIL_AGE threshold, leaving a single 12h WARN_AGE threshold. Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 The
external_usersdoctor check could previously flip the overall doctor result to FAILING when a session had been continuously connected for 24h or more. Operators don't want a forgotten interactive/RDP session to take the whole healthcheck down.This downgrades the check so a long-lived session can only ever warn:
FAIL_AGEthreshold and itsCheck::failbranch.