-
Notifications
You must be signed in to change notification settings - Fork 20
chore: make justfile fully compatible with Windows/PowerShell #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MusabYK
wants to merge
4
commits into
bitcoindevkit:main
Choose a base branch
from
MusabYK:chore/windows-justfile-compat
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
f0ede1e
chore: make justfile fully compatible with Windows/PowerShell
MusabYK cd8c706
Fix: Add Linux support to 'repo' recipe using xdg-open.
MusabYK cc2505c
fix(justfile): replace multi-line interpolations with variables
MusabYK 0822dce
add dart pub get to windows_generate_bindings
MusabYK File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,20 @@ | ||
| # Allow experimental features like [group(...)] | ||
| set unstable := true | ||
|
|
||
| set shell := ["sh", "-c"] | ||
|
|
||
| set windows-shell := ["powershell.exe", "-Command"] | ||
|
|
||
| windows_generate_bindings := "cd native; if (-not $?) { exit 1 }; cargo build --profile dev; if (-not $?) { exit 1 }; cargo run --profile dev --bin uniffi-bindgen -- generate --library target/debug/bdk_dart_ffi.dll --language dart --config uniffi.toml --out-dir ../lib/" | ||
|
|
||
| unix_generate_bindings := "bash ./scripts/generate_bindings.sh" | ||
|
|
||
| windows_clean := "'.dart_tool', 'build', 'native/target', 'coverage', 'bdk_demo/.dart_tool', 'bdk_demo/build', 'example/.dart_tool', 'example/build' | Where-Object { Test-Path $_ } | ForEach-Object { Remove-Item -Recurse -Force $_ }" | ||
|
|
||
| unix_clean := "rm -rf .dart_tool/ build/ native/target/ coverage/ bdk_demo/.dart_tool/ bdk_demo/build/ example/.dart_tool/ example/build/" | ||
|
|
||
| opener := if os_family() == "windows" { "Start-Process" } else if os() == "macos" { "open" } else { "xdg-open" } | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. small nit here: repo uses os_family() but bindings use os(). Probably fine, but worth picking one and sticking with it. |
||
|
|
||
| [group("Repo")] | ||
| [doc("Default command; list all available commands.")] | ||
| @list: | ||
|
|
@@ -6,7 +23,7 @@ | |
| [group("Repo")] | ||
| [doc("Open repo on GitHub in your default browser.")] | ||
| repo: | ||
| open https://github.com/bitcoindevkit/bdk-dart | ||
| @{{ opener }} "https://github.com/bitcoindevkit/bdk-dart" | ||
|
|
||
| [group("Dart")] | ||
| [doc("Format the Dart codebase.")] | ||
|
|
@@ -31,17 +48,19 @@ test *ARGS: | |
| [group("Bindings")] | ||
| [doc("Build native library and regenerate bindings.")] | ||
| generate-bindings: | ||
| bash ./scripts/generate_bindings.sh | ||
| {{ if os() == "windows" { windows_generate_bindings } else { unix_generate_bindings } }} | ||
|
|
||
| [group("Demo")] | ||
| [doc("Run Flutter analysis for the demo app.")] | ||
| [working-directory: "bdk_demo"] | ||
| demo-analyze: | ||
| cd bdk_demo && flutter analyze | ||
| flutter analyze | ||
|
|
||
| [group("Demo")] | ||
| [doc("Run Flutter tests for the demo app.")] | ||
| [working-directory: "bdk_demo"] | ||
| demo-test *ARGS: | ||
| cd bdk_demo && flutter test {{ if ARGS == "" { "" } else { ARGS } }} | ||
| flutter test {{ if ARGS == "" { "" } else { ARGS } }} | ||
|
|
||
| [group("CI")] | ||
| [doc("Run the same checks as CI.")] | ||
|
|
@@ -55,11 +74,4 @@ ci: | |
| [group("Dart")] | ||
| [doc("Remove build and tool artifacts to start fresh.")] | ||
| clean: | ||
| rm -rf .dart_tool/ | ||
| rm -rf build/ | ||
| rm -rf native/target/ | ||
| rm -rf coverage/ | ||
| rm -rf bdk_demo/.dart_tool/ | ||
| rm -rf bdk_demo/build/ | ||
| rm -rf example/.dart_tool/ | ||
| rm -rf example/build/ | ||
| {{ if os() == "windows" { windows_clean } else { unix_clean } }} | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Windows path skips
dart pub getfrom the bash script. Is that intentional?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely not. Thanks for checking and pointing it out.