Skip to content

Fix event retaining#794

Merged
ArnyminerZ merged 1 commit intomainfrom
793-782-breaks-sync
Jan 20, 2026
Merged

Fix event retaining#794
ArnyminerZ merged 1 commit intomainfrom
793-782-breaks-sync

Conversation

@ArnyminerZ
Copy link
Copy Markdown
Member

Purpose

After #782, events are no longer retained. _SYNC_ID is set to null, and therefore all added events are removed when calling retainByUID. This is caused by synctools using UID_2445 instead of _SYNC_ID.

See: https://developer.android.com/reference/android/provider/CalendarContract.EventsColumns#UID_2445

Short description

  • Replaced usages of Events._SYNC_ID with Events.UID_2445.

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ self-assigned this Jan 19, 2026
@ArnyminerZ ArnyminerZ added the bug label Jan 19, 2026
@ArnyminerZ ArnyminerZ linked an issue Jan 19, 2026 that may be closed by this pull request
@ArnyminerZ ArnyminerZ marked this pull request as ready for review January 19, 2026 17:47
@ArnyminerZ ArnyminerZ requested a review from sunkup January 19, 2026 17:47
Copy link
Copy Markdown
Member

@sunkup sunkup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Events.UID_2445 seems to exist at least since android 4.2.1 .

@ArnyminerZ ArnyminerZ merged commit 8c9bade into main Jan 20, 2026
5 checks passed
@ArnyminerZ ArnyminerZ deleted the 793-782-breaks-sync branch January 20, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#782 breaks sync

2 participants